Fix LD_LIBRARY_PATH export in BUILD_NOTES_tch.txt#569
Open
SuhasSrinivasan wants to merge 3 commits intonanoporetech:masterfrom
Open
Fix LD_LIBRARY_PATH export in BUILD_NOTES_tch.txt#569SuhasSrinivasan wants to merge 3 commits intonanoporetech:masterfrom
SuhasSrinivasan wants to merge 3 commits intonanoporetech:masterfrom
Conversation
Update LD_LIBRARY_PATH export format for compatibility.
There was a problem hiding this comment.
Pull request overview
This PR fixes the LD_LIBRARY_PATH export command in the libtorch build documentation to preserve existing environment variables instead of overwriting them. This addresses issue #491 where users with CUDA installations already have LD_LIBRARY_PATH set and the previous command would overwrite those values.
Changes:
- Updated the LD_LIBRARY_PATH export to use shell parameter expansion that appends to existing values instead of replacing them
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update LD_LIBRARY_PATH export format for compatibility.
As discussed in #491