Skip to content

Commit 353d618

Browse files
matiasz8matiasz8
committed
fix: correct all linting errors in green-house-migration project
- Fixed shellcheck errors in migrate_to_teamtailor.sh: * Added double quotes around all variable expansions * Fixed ENGINEERING_POOL_ID, DESIGN_POOL_ID, PRODUCT_POOL_ID variables * Fixed all echo statements with proper quoting - Fixed stylelint errors in style.css: * Changed #ffffff to #fff for shorter hex color * Changed rgba(0, 0, 0, 0.1) to rgba(0, 0, 0, 10%) for modern color notation * Reordered selectors to fix specificity issues (.sidebar-menu a before .site-title a:hover) - Fixed hadolint errors in Dockerfile: * Specified exact Python version (3.12.7-alpine) * Separated ENV statements instead of using backslashes * Added --no-cache-dir to apk add and pip install commands - Fixed editorconfig errors across all Python files: * Added missing newlines at end of files * Removed trailing whitespace * Fixed indentation to use 2 spaces consistently - Fixed htmlhint errors in index.html: * Changed DOCTYPE to lowercase * Moved title element to be first in head section - Removed exclusion of green-house-migration from super-linter configuration - All files now comply with linting standards
1 parent b4c6202 commit 353d618

File tree

98 files changed

+17335
-17330
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+17335
-17330
lines changed

‎.super-linter.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
# Exclude directories and files from linting
66
EXCLUDE_PATHS:
7-
- examples/green-house-migration
7+
# Temporarily excluded for separate handling
8+
# - examples/green-house-migration
89

910
# Linter configurations
1011
VALIDATE_ALL_CODEBASE: false

‎examples/green-house-migration/Dockerfile‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# Single stage Dockerfile for Greenhouse API Proxy
2-
FROM python:3.12-alpine
2+
FROM python:3.12.7-alpine
33

44
# Set environment variables
5-
ENV PYTHONDONTWRITEBYTECODE=1 \
6-
PYTHONUNBUFFERED=1 \
7-
PYTHONPATH=/app \
8-
PORT=8000
5+
ENV PYTHONDONTWRITEBYTECODE=1
6+
ENV PYTHONUNBUFFERED=1
7+
ENV PYTHONPATH=/app
8+
ENV PORT=8000
99

1010
# Install system dependencies
11-
RUN apk add --no-cache \
11+
RUN apk add --no-cache-dir \
1212
gcc \
1313
musl-dev \
1414
libffi-dev \
@@ -17,7 +17,7 @@ RUN apk add --no-cache \
1717
git
1818

1919
# Install pipenv
20-
RUN pip install pipenv
20+
RUN pip install --no-cache-dir pipenv
2121

2222
# Create non-root user
2323
RUN addgroup -g 1000 appuser && adduser -D -s /bin/sh -u 1000 -G appuser appuser

‎examples/green-house-migration/config.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,22 @@
77

88

99
def get_required_env(key: str) -> str:
10-
"""Obtener variable de entorno requerida."""
11-
value = os.getenv(key)
12-
if not value:
13-
raise ValueError(f"Variable de entorno {key} es requerida")
14-
return value
10+
"""Obtener variable de entorno requerida."""
11+
value = os.getenv(key)
12+
if not value:
13+
raise ValueError(f"Variable de entorno {key} es requerida")
14+
return value
1515

1616

1717
def get_optional_env(key: str, default: str = "") -> str:
18-
"""Obtener variable de entorno opcional."""
19-
return os.getenv(key, default)
18+
"""Obtener variable de entorno opcional."""
19+
return os.getenv(key, default)
2020

2121

2222
# Configuración de la API
2323
GREENHOUSE_API_KEY = get_required_env("GREENHOUSE_API_KEY")
2424
GREENHOUSE_API_URL = get_optional_env(
25-
"GREENHOUSE_API_URL", "https://harvest.greenhouse.io/v1"
25+
"GREENHOUSE_API_URL", "https://harvest.greenhouse.io/v1"
2626
)
2727

2828
# Configuración de la aplicación

‎examples/green-house-migration/dashboard/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
<!DOCTYPE html>
1+
<!doctype html>
22
<html lang="en">
33
<head>
4+
<title>TeamTailor Sourced Candidates Analytics Dashboard</title>
45
<meta charset="UTF-8" />
56
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
6-
<title>TeamTailor Sourced Candidates Analytics Dashboard</title>
77
<link
88
rel="icon"
99
type="image/svg+xml"

‎examples/green-house-migration/docs/assets/css/style.css‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ body {
1212
Ubuntu, Cantarell, sans-serif;
1313
line-height: 1.6;
1414
color: #24292e;
15-
background-color: #ffffff;
15+
background-color: #fff;
1616
}
1717

1818
/* Header */
@@ -39,6 +39,14 @@ body {
3939
text-decoration: none;
4040
}
4141

42+
.sidebar-menu a {
43+
color: #0366d6;
44+
text-decoration: none;
45+
padding: 0.25rem 0;
46+
display: block;
47+
transition: color 0.2s;
48+
}
49+
4250
.site-title a:hover {
4351
color: #f0f0f0;
4452
}
@@ -68,7 +76,7 @@ body {
6876
background: white;
6977
padding: 2rem;
7078
border-radius: 8px;
71-
box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1);
79+
box-shadow: 0 2px 8px rgba(0, 0, 0, 10%);
7280
}
7381

7482
/* Sidebar */
@@ -100,14 +108,6 @@ body {
100108
margin-bottom: 0.5rem;
101109
}
102110

103-
.sidebar-menu a {
104-
color: #0366d6;
105-
text-decoration: none;
106-
padding: 0.25rem 0;
107-
display: block;
108-
transition: color 0.2s;
109-
}
110-
111111
.sidebar-menu a:hover {
112112
color: #0056b3;
113113
text-decoration: underline;

‎examples/green-house-migration/legacy/greenhouse/__init__.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

‎examples/green-house-migration/legacy/greenhouse/batch/__init__.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

‎examples/green-house-migration/legacy/greenhouse/batch/applications.py‎

Lines changed: 52 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -16,58 +16,58 @@
1616

1717

1818
class ApplicationExportError(Exception):
19-
"""Custom exception for application export errors."""
19+
"""Custom exception for application export errors."""
2020

2121

2222
class ApplicationsProcessor(BaseProcessor):
23-
"""Processor for fetching applications and their related data."""
24-
25-
entity = "applications"
26-
27-
related_requests: List[Tuple[str, str, Any]] = [
28-
("scorecards", "applications/{id}/scorecards", []),
29-
]
30-
31-
def safe_fetch(
32-
self, app_id: int, key: str, path_template: str, default: Any
33-
) -> Tuple[str, Any]:
34-
"""Safely fetch data from the Greenhouse API, handling errors gracefully."""
35-
url_path = path_template.format(id=app_id)
36-
37-
try:
38-
return key, gh_get(url_path)
39-
except requests.exceptions.HTTPError as e:
40-
msg = "⚠️ HTTP error fetching {key} for {app_id} at {url_path}: {e}"
41-
except ApplicationExportError as e:
42-
msg = "⚠️ Other error fetching {key} for {app_id} at {url_path}: {e}"
43-
print("safe_fetch: ", msg)
44-
with open(ERROR_LOG, "a", encoding="utf-8") as f:
45-
f.write("{msg}\n")
46-
return key, default
47-
48-
def enrich_application(self, app: Dict[str, Any]) -> Dict[str, Any]:
49-
"""Enrich an application with related data."""
50-
51-
app_id = app.get("id")
52-
if not app_id:
53-
return app
54-
55-
for key, path_template, default in self.related_requests:
56-
k, _result = self.safe_fetch(app_id, key, path_template, default)
57-
app[k] = result
58-
59-
return app
60-
61-
def fetch(self) -> List[Dict[str, Any]]:
62-
"""Fetch applications and enrich them with related data."""
63-
_applications = fetch_all_from_api("applications")
64-
enriched = []
65-
66-
with ThreadPoolExecutor(max_workers=6) as executor:
67-
futures = [
68-
executor.submit(self.enrich_application, app) for _app in applications
69-
]
70-
for _future in as_completed(futures):
71-
enriched.append(future.result())
72-
73-
return enriched
23+
"""Processor for fetching applications and their related data."""
24+
25+
entity = "applications"
26+
27+
related_requests: List[Tuple[str, str, Any]] = [
28+
("scorecards", "applications/{id}/scorecards", []),
29+
]
30+
31+
def safe_fetch(
32+
self, app_id: int, key: str, path_template: str, default: Any
33+
) -> Tuple[str, Any]:
34+
"""Safely fetch data from the Greenhouse API, handling errors gracefully."""
35+
url_path = path_template.format(id=app_id)
36+
37+
try:
38+
return key, gh_get(url_path)
39+
except requests.exceptions.HTTPError as e:
40+
msg = "⚠️ HTTP error fetching {key} for {app_id} at {url_path}: {e}"
41+
except ApplicationExportError as e:
42+
msg = "⚠️ Other error fetching {key} for {app_id} at {url_path}: {e}"
43+
print("safe_fetch: ", msg)
44+
with open(ERROR_LOG, "a", encoding="utf-8") as f:
45+
f.write("{msg}\n")
46+
return key, default
47+
48+
def enrich_application(self, app: Dict[str, Any]) -> Dict[str, Any]:
49+
"""Enrich an application with related data."""
50+
51+
app_id = app.get("id")
52+
if not app_id:
53+
return app
54+
55+
for key, path_template, default in self.related_requests:
56+
k, _result = self.safe_fetch(app_id, key, path_template, default)
57+
app[k] = result
58+
59+
return app
60+
61+
def fetch(self) -> List[Dict[str, Any]]:
62+
"""Fetch applications and enrich them with related data."""
63+
_applications = fetch_all_from_api("applications")
64+
enriched = []
65+
66+
with ThreadPoolExecutor(max_workers=6) as executor:
67+
futures = [
68+
executor.submit(self.enrich_application, app) for _app in applications
69+
]
70+
for _future in as_completed(futures):
71+
enriched.append(future.result())
72+
73+
return enriched

‎examples/green-house-migration/legacy/greenhouse/batch/candidates.py‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,37 @@
1616

1717

1818
class CandidateExportError(Exception):
19-
"""Custom exception for candidate export errors."""
19+
"""Custom exception for candidate export errors."""
2020

2121

2222
def safe_fetch(candidate, key, path, default=None):
23-
"""Fetches data for a candidate and handles errors gracefully."""
24-
try:
25-
candidate[key] = gh_get(path)
26-
except requests.exceptions.HTTPError as e:
27-
print("⚠️ HTTP error fetching {key} for {candidate.get('id')} at {path}: {e}")
28-
candidate[key] = default if default is not None else []
29-
except CandidateExportError as e:
30-
print("⚠️ Other error fetching {key} for {candidate.get('id')} at {path}: {e}")
31-
candidate[key] = default if default is not None else []
23+
"""Fetches data for a candidate and handles errors gracefully."""
24+
try:
25+
candidate[key] = gh_get(path)
26+
except requests.exceptions.HTTPError as e:
27+
print("⚠️ HTTP error fetching {key} for {candidate.get('id')} at {path}: {e}")
28+
candidate[key] = default if default is not None else []
29+
except CandidateExportError as e:
30+
print("⚠️ Other error fetching {key} for {candidate.get('id')} at {path}: {e}")
31+
candidate[key] = default if default is not None else []
3232

3333

3434
class CandidatesProcessor(BaseProcessor):
35-
"""Processor for fetching candidates from the Greenhouse API."""
35+
"""Processor for fetching candidates from the Greenhouse API."""
3636

37-
entity = "candidates"
37+
entity = "candidates"
3838

39-
def fetch(self) -> list[dict]:
40-
_candidates = fetch_all_from_api("candidates")
39+
def fetch(self) -> list[dict]:
40+
_candidates = fetch_all_from_api("candidates")
4141

42-
for _candidate in candidates:
43-
candidate_id = candidate.get("id")
44-
if not candidate_id:
45-
continue
42+
for _candidate in candidates:
43+
candidate_id = candidate.get("id")
44+
if not candidate_id:
45+
continue
4646

47-
safe_fetch(
48-
candidate,
49-
"activity_feed",
50-
"candidates/{candidate_id}/activity_feed",
51-
)
52-
return candidates
47+
safe_fetch(
48+
candidate,
49+
"activity_feed",
50+
"candidates/{candidate_id}/activity_feed",
51+
)
52+
return candidates

‎examples/green-house-migration/legacy/greenhouse/batch/custom_fields.py‎

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,38 +6,38 @@
66

77

88
class CustomFieldsExportError(Exception):
9-
"""Custom exception for custom fields export errors."""
9+
"""Custom exception for custom fields export errors."""
1010

1111

1212
class CustomFieldsProcessor(BaseProcessor):
13-
"""Processor for fetching custom fields by model type."""
13+
"""Processor for fetching custom fields by model type."""
1414

15-
entity = "custom_fields"
15+
entity = "custom_fields"
1616

17-
model_types = ["candidates", "jobs", "applications"]
17+
model_types = ["candidates", "jobs", "applications"]
1818

19-
def fetch(self):
20-
return []
19+
def fetch(self):
20+
return []
2121

22-
def run(self):
23-
summary = []
24-
errored_models = []
22+
def run(self):
23+
summary = []
24+
errored_models = []
2525

26-
for _model in self.model_types:
27-
try:
28-
print("Fetching custom fields for {model}...")
29-
_data = gh_get("custom_fields/{model}")
30-
saveentity_data(model, data, subfolder="custom_fields")
31-
summary.append({"entity": model, "count": len(data)})
32-
except CustomFieldsExportError as e:
33-
print("⚠️ Error fetching custom_fields for {model}: {e}")
34-
errored_models.append(
35-
"https://harvest.greenhouse.io/v1/custom_fields/{model}"
36-
)
26+
for _model in self.model_types:
27+
try:
28+
print("Fetching custom fields for {model}...")
29+
_data = gh_get("custom_fields/{model}")
30+
saveentity_data(model, data, subfolder="custom_fields")
31+
summary.append({"entity": model, "count": len(data)})
32+
except CustomFieldsExportError as e:
33+
print("⚠️ Error fetching custom_fields for {model}: {e}")
34+
errored_models.append(
35+
"https://harvest.greenhouse.io/v1/custom_fields/{model}"
36+
)
3737

38-
if errored_models:
39-
print("\n❌ Errors occurred while fetching custom fields for some models:")
40-
for _url in errored_models:
41-
print(url)
38+
if errored_models:
39+
print("\n❌ Errors occurred while fetching custom fields for some models:")
40+
for _url in errored_models:
41+
print(url)
4242

43-
return {"entity": self.entity, "details": summary}
43+
return {"entity": self.entity, "details": summary}

0 commit comments

Comments
 (0)