Merge pull request #9 from namtranase/dev

Dev

Author: namtranase

.clang-format

@@ -0,0 +1,2 @@
+Language: Cpp
+BasedOnStyle: Google

.gitignore

@@ -160,4 +160,7 @@ cython_debug/
 #.idea/
 
 # Vscode
-.vscode/
+.vscode/
+
+#p Precommit
+.pre-commit-config.yaml

CMakeLists.txt

@@ -11,7 +11,7 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 FetchContent_Declare(sentencepiece GIT_REPOSITORY https://github.com/google/sentencepiece GIT_TAG 53de76561cfc149d3c01037f0595669ad32a5e7c)
 FetchContent_MakeAvailable(sentencepiece)
 
-FetchContent_Declare(gemma GIT_REPOSITORY https://github.com/google/gemma.cpp GIT_TAG e29cd566cf3367671e8f59419a04e308796a7c57)
+FetchContent_Declare(gemma GIT_REPOSITORY https://github.com/google/gemma.cpp GIT_TAG 8fb44ed6dd123f63dca95c20c561e8ca1de511d7)
 FetchContent_MakeAvailable(gemma)
 
 FetchContent_Declare(highway GIT_REPOSITORY https://github.com/google/highway.git GIT_TAG da250571a45826b21eebbddc1e50d0c1137dee5f)
@@ -30,3 +30,5 @@ FetchContent_GetProperties(gemma)
 FetchContent_GetProperties(sentencepiece)
 target_include_directories(pygemma PRIVATE ${gemma_SOURCE_DIR})
 target_include_directories(pygemma PRIVATE ${sentencepiece_SOURCE_DIR})
+target_compile_definitions(libgemma PRIVATE $<$<PLATFORM_ID:Windows>:_CRT_SECURE_NO_WARNINGS NOMINMAX>)
+target_compile_options(libgemma PRIVATE $<$<PLATFORM_ID:Windows>:-Wno-deprecated-declarations>)

DEVELOPERS.md

@@ -0,0 +1,2 @@
+## 🤝 Contributing
+Contributions are welcome. Please clone the repository, push your changes to a new branch, and submit a pull request.

requirements.txt

@@ -1,2 +0,0 @@
-pybind11
-pre-commit

setup.py

@@ -3,6 +3,7 @@
 import sys
 from setuptools import setup, find_packages, Extension
 from setuptools.command.build_ext import build_ext
+import platform
 
 
 class CMakeExtension(Extension):
@@ -39,7 +40,7 @@ def build_extension(self, ext):
             "--",
             "-j",
             "12",
-        ]  # Specifies the number of jobs to run simultaneously
+        ]
 
         if not os.path.exists(self.build_temp):
             os.makedirs(self.build_temp)
@@ -58,7 +59,7 @@ def build_extension(self, ext):
     version="0.1.2",
     author="Nam Tran",
     author_email="namtran.ase@gmail.com",
-    description="A Python package with a C++ backend using gemma.",
+    description="A Python package with a C++ backend using gemma.cpp",
     long_description="""
     This package provides Python bindings to a C++ library using pybind11.
     """,