Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about CastSpellHook + buffer #27

Open
pmaccamp opened this issue Oct 26, 2023 · 1 comment
Open

Question about CastSpellHook + buffer #27

pmaccamp opened this issue Oct 26, 2023 · 1 comment

Comments

@pmaccamp
Copy link

Hi,

I was playing around with this on turtle wow where I have 150ms ping. I was getting average fireball cast times of around 3.15 secs when timing 20 casts with a stopwatch and wanted to see if I could improve that further.

Running nampower in a debugger I noticed that CastSpellHook was only getting called every ~150ms when spamming cast right before the current cast ended. So if you got unlucky could end up waiting that long before CastSpell got called even when off cooldown. I was curious if you knew any way to improve this?

Also it didn't seem like there was any buffer to counteract changes in latency that might cause a cast to fail on the server due to arriving too early?

Thanks!

@namreeb
Copy link
Owner

namreeb commented Nov 23, 2023

I have no explanation for why the timing was slow for you. If it worked that way all the time then nampower would make things worse, not better. I've never experienced this. And there isn't any buffer by design. The goal is to essentially remove the client-side checks, and just allow the client to spam the server with cast attempts. If it arrives too soon, that shouldn't be a problem because the server will reject it (unless the server is broken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants