Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Automatic1111 1.6 #20

Open
abellos opened this issue Sep 11, 2023 · 11 comments
Open

Problem with Automatic1111 1.6 #20

abellos opened this issue Sep 11, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@abellos
Copy link

abellos commented Sep 11, 2023

In 1.6 version of automatic1111 web ui the thumbnail are broken and not visible, the image are not written in the data folder of extension, pagination not work anymore

@namkazt
Copy link
Owner

namkazt commented Sep 13, 2023

thanks for the info, i will check it out.

@namkazt namkazt added the bug Something isn't working label Sep 13, 2023
@zethriller
Copy link

It may be related to this piece:

// prompt_history.js line 99
function promptHistoryAutoRefresh() {
    // hijack ui
    const btn_c = gradioApp().querySelector('#txt2img_style_create')

Since A1111 1.6 this button doesn't exist anymore, btn_c is null and the rest of the function will fail.
(Unless you use some restore old ui extensions, don't know the name but they do exist)

Proposed fix:

function promptHistoryAutoRefresh() {
    // hijack ui
    const btn_c = gradioApp().querySelector('#txt2img_styles_edit_button');

@namkazt
Copy link
Owner

namkazt commented Sep 19, 2023

thanks @zethriller, i will check it as soon as i have some time.

@namkazt
Copy link
Owner

namkazt commented Sep 19, 2023

fixed in 53cb542

@namkazt namkazt closed this as completed Sep 19, 2023
@namkazt namkazt reopened this Sep 19, 2023
@namkazt
Copy link
Owner

namkazt commented Sep 19, 2023

aw sorry, it only fix the display problem, the save history still has problem, i will debug somemore

@zethriller
Copy link

I have the feeling it starts locking itself up when a page is added (20 items per page ?) - until you refresh the webui (F5 in browser, no need for a full relaunch)
This is still an unreliable lead, i can't reproduce it with 21 batches of 1x1 and the few debugs outputs i've added give nothing.
However with somewhere about 50 generations without switching to the prompt history tab, it starts locking up. (!!)
I hope for the sake of us all that the trigger is lower than that, i can't tell exactly how high it is.
Then those pop up in the console:

Prompt History - prev_func(): global_state.config_changed: True
Prompt History - next_func(): global_state.config_changed: True

And it'll stay like that until you refresh the webui.
If this stays on true, prev/next and possibly the other buttons become unusable.
Ref:

# prompt_history_script.py:179
def prev_func():
  global current_page
  print("Prompt History - prev_func(): global_state.config_changed: " + str(global_state.config_changed))
  if global_state.config_changed: return

Data is recorded, i'm monitoring the data\ folder, preview images keep coming in. data.json file looks ok as well.
I'm not fluent at all with python so i'm a bit nervous about going deeper in code than a few print(), sorry lol

Hope this helps, though.

@namkazt
Copy link
Owner

namkazt commented Oct 23, 2023

that weird, i already test pagination few times but with smaller page size ( around 3 )

@zethriller
Copy link

Latest revision (3fb37ab) has fixed both saving to history and paging.
I'm way above a single page on today's generations and i can tell it works. 👍

@namkazt
Copy link
Owner

namkazt commented Oct 31, 2023

nice, close now, feel free to open new issue if you have any problem.

@namkazt namkazt closed this as completed Oct 31, 2023
@terrrst
Copy link

terrrst commented Nov 6, 2023

Hello. I'm sorry, but it still doesn't work for me: previews don't get stored in /data folder. Pagination works ok.

I reinstalled stable-diffusion-webui and sd-webui-prompt-history but still no previews. I use Windows 11.

Thanks.

version: v1.6.0-2-g4afaaf8a  •  python: 3.10.6  •  torch: 2.0.1+cu118  •  xformers: 0.0.20  •  gradio: 3.41.2

@namkazt
Copy link
Owner

namkazt commented Nov 7, 2023

Hello. I'm sorry, but it still doesn't work for me: previews don't get stored in /data folder. Pagination works ok.

I reinstalled stable-diffusion-webui and sd-webui-prompt-history but still no previews. I use Windows 11.

Thanks.

version: v1.6.0-2-g4afaaf8a  •  python: 3.10.6  •  torch: 2.0.1+cu118  •  xformers: 0.0.20  •  gradio: 3.41.2

Can you try to open settings page and set thumbnail to NOT none

@namkazt namkazt reopened this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants