Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for CoAP over tcp #12

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Implement support for CoAP over tcp #12

merged 5 commits into from
Jul 3, 2023

Conversation

petardimitrijevic
Copy link
Contributor

This pull request implements CoAP over TCP.

@JKRhb JKRhb requested a review from pulsastrix June 28, 2023 13:16
@JKRhb JKRhb added the enhancement New feature or request label Jun 28, 2023
falko17
falko17 requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@falko17 falko17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments regarding documentation that references UDP instead of TCP, the rest looks fine to me.

libcoap/src/transport/tcp.rs Outdated Show resolved Hide resolved
libcoap/tests/tcp_client_server_test.rs Outdated Show resolved Hide resolved
@pulsastrix
Copy link
Member

pulsastrix commented Jun 28, 2023 •
edited
Loading

Thanks for the PR!
LGTM aside from what @falko17 already mentioned.

Regarding the test failures: It seems that rust-lang/rust#109044 is the cause.
I have pushed a commit that switches the test jobs over to nightly to main, so rebasing the PR branch should fix the checks.

@petardimitrijevic
Update comments
046d3fa 
Fix copy/paste comments. Everything should reffer to the TCP
functionality.
@petardimitrijevic
Copy link
Contributor Author

I have fixed the comments. The changes are pushed.

Thanks for the PR! LGTM aside from what @falko17 already mentioned.

Glad that I could help.

@pulsastrix pulsastrix requested a review from falko17 June 29, 2023 10:11
@petardimitrijevic
Copy link
Contributor Author

I've rebased the branch on main, so that it includes @pulsastrix switch to nightly toolchain.
The pipeline should pass with this commit.

@JKRhb
Copy link
Member

JKRhb commented Jul 1, 2023

@pulsastrix @falko17 I guess this PR should now be ready to be merged, right? Or does the coverage job need to be fixed first?

@pulsastrix
Copy link
Member

@JKRhb the coverage job failure is due to the fact that this PR comes from a fork, which causes the CI pipeline to have insufficient permissions to create comments in the main repository.
Will merge now.

pulsastrix added a commit that referenced this pull request Jul 3, 2023
@pulsastrix
merge: pull request #12 from petardimitrijevic/coap_tcp
cc49792
@pulsastrix pulsastrix merged commit 0e17941 into namib-project:main Jul 3, 2023
@pulsastrix pulsastrix mentioned this pull request Jul 3, 2023
Open
2 tasks
@petardimitrijevic petardimitrijevic deleted the coap_tcp branch July 7, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falko17 falko17 falko17 approved these changes

@pulsastrix pulsastrix pulsastrix approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petardimitrijevic @pulsastrix @JKRhb @falko17