Open
Conversation
Contributor
|
Isn't the orange check mark too strange, because check marks are usually green, while warnings are orange. There are also images of these icons at https://fluent2.microsoft.design/color. |
|
The orange check-mark looks like it is decoration, not a semantic color indicating important information; or at worse might convey a warning, but that is incongruent with the tick symbol indicating success. Notwithstanding the semantic coloring, the check-mark would be better using the Fluent2 mark with the better proportioned tick. Fluent2 Semantic Colors + IconsNote the design here uses consistent coloring and iconography. The link that @Jesse205 provided explains it quite well. AccessibilityAlso you need to consider accessibility. Your proposal
How a colorblind person may perceive these
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.