Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add option for Blake3-512 #56

Closed
tERyceNzAchE opened this issue Jan 31, 2021 · 3 comments
Closed

Feature Request: Add option for Blake3-512 #56

tERyceNzAchE opened this issue Jan 31, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@tERyceNzAchE
Copy link

Add option to create Blake3-512 hashes.
@tERyceNzAchE tERyceNzAchE changed the title Feature Request: Add option cor Blake3-512 Feature Request: Add option for Blake3-512 Jan 31, 2021
@namazso namazso added the enhancement New feature or request label Feb 1, 2021
@namazso
Copy link
Owner

namazso commented Feb 1, 2021

Is it used anywhere relevant? algorithms like BLAKE3 and several others from the XKCP have user-defined output sizes. Since the current code really doesn't support exposing this as an option to the user, only the default sizes are added (since they are the ones used practically everywhere), which is 256 bits for BLAKE3.

@tERyceNzAchE
Copy link
Author

Blake3-512 is pretty common. Uses for sizes other than 256 and 512 are pretty rare.
I would suggest keeping the current implementation as-is, and adding an option for BLAKE3-512 (much like for SHA).

@namazso namazso closed this as completed in 36dbd33 Mar 3, 2021
@divinity76
Copy link

Is it used anywhere relevant?

is 512 bits even useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@divinity76 @namazso @tERyceNzAchE