Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notwasm feature #10

Closed
JakkuSakura opened this issue Jun 1, 2021 · 2 comments
Closed

Remove notwasm feature #10

JakkuSakura opened this issue Jun 1, 2021 · 2 comments

Comments

@JakkuSakura
Copy link
Contributor

Once you specify each test with its feature, and have #![cfg(target = "wasm")],it should work fine without notwasm feature.
See https://github.com/qiujiangkun/async_executors/blob/dev/Cargo.toml

Though I can't get wasm working in my machine either way(it stucks during installation of wasm). You can try it out though.

@najamelan
Copy link
Owner

Once you specify each test with its feature, and have #![cfg(target = "wasm")],it should work fine without notwasm feature.

No it doesn't:

All these inconveniences in the code are there for a reason. Not because I like them. I don't like notwasm feature, but I have no way to get it to work without.

@najamelan
Copy link
Owner

As this is blocked for the moment I will close it for now. Feel free to re-open if there is a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants