Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the core prop group can only be as high as 15 #23

Open
HowardBaxton opened this issue Jan 24, 2019 · 2 comments
Open

In the core prop group can only be as high as 15 #23

HowardBaxton opened this issue Jan 24, 2019 · 2 comments
Assignees
Milestone

Comments

@HowardBaxton
Copy link
Contributor

Line 467 of the Core script we find this line:
rezParam=rezParam | (quietMode << 1) | ((propGroup & 0x2F) << 2);

The calculation (propGroup & 0x2F) will only allow 0 to 15 group numbers, after that, they start over at 0 again, so prop group of 16 will become 0 and be sent to the prop plugin as normal prop, etc.

The wiki states the limit is 63 (https://github.com/nPoseTeam/nPose-V3/wiki/NC-Contents#prop).
Which do we want the limit to be?

@LeonaMorro
Copy link
Member

You are right. It should be &0x3F to work with 64 groups.
With the current implementation we can use the group numbers 0-15 and 32-47. 16-31 will be transformed to 0-15 and 48-63 will be transformed to 32-47

Due to copy & paste the same wrong calculation is inside the prop script. So I guess the "hotfix" will be: Change it inside the wiki to 16. I will do so in a minute.

@LeonaMorro
Copy link
Member

To use 0-63 groups. we will need nPose V3.11 or newer and the prop script V1.01 or newer. This has to be documented.

@LeonaMorro LeonaMorro reopened this Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants