Add changes to fix bad input from fuzzing, Fixes #210#217
Merged
milkshakeuk merged 3 commits intomasterfrom Jun 1, 2021
Merged
Add changes to fix bad input from fuzzing, Fixes #210#217milkshakeuk merged 3 commits intomasterfrom
milkshakeuk merged 3 commits intomasterfrom
Conversation
* Add new SupportClass.CharsAreUnique method * Add check for unique encoding characters in EncodingCharacters.cs (was causing Stack Overflow) * Add unit tests for changes plus additional Bad Input files to existing test
Member
Author
|
@JlKmn could you also have a quick review please |
This comment has been minimized.
This comment has been minimized.
AMCN41R
reviewed
Jun 1, 2021
AMCN41R
approved these changes
Jun 1, 2021
This comment has been minimized.
This comment has been minimized.
…espace (and Null) characters being used as encoding characters or as the field Seperator (MSH-1) + unit tests
milkshakeuk
force-pushed
the
FuzzBadInputFixes3
branch
from
e890132 to
ea59932
Compare
Unit Test Results 5 files 105 suites 13s ⏱️ Results for commit ea59932. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210
SupportClass.CharsAreUniquemethodEncodingCharacters.cs(was causing Stack Overflow)EncodingCharacters.csto prevent whitespace (and Null) characters being used as encoding characters or as the field Seperator (MSH-1) + unit tests.