Merged
Conversation
Member
Author
|
@duaneedwards @ryankelley @Usualdosage @AMCN41R |
AMCN41R
approved these changes
Jan 30, 2021
Collaborator
AMCN41R
left a comment
AMCN41R
left a comment
There was a problem hiding this comment.
@milkshakeuk - looks good to me - just one comment about a possible null ref. Looks like it'll get caught anyway, but might want to review.
This was
linked to
issues
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datatype for
OBX-5is specified inOBX-2, the first commit fixes an issue when the specified datatype fromOBX-2could not be constructed forOBX-5because the required constructors were missing.fixes #62, fixes #85, fixes #133
XAD,XON,XTNdatatypes for hl7 v2.7.1 up to 2.8.1 have incorrect recursive datatypes leading toStackOverflowException.The second commit fixes this by correcting those datatypes.
fixes #86, fixes #109
The
OBX-5datatype for hl7 v2.1 is incorrectly set toSTwhen it should beVaries. The last commit fixes this.fixes #45