Skip to content

#128 > NHapi.Base > Formatted XML License Comments#135

Merged
milkshakeuk merged 2 commits intonHapiNET:masterfrom
AMCN41R:128-XmlCommentRefactor
Jan 29, 2021
Merged

#128 > NHapi.Base > Formatted XML License Comments#135
milkshakeuk merged 2 commits intonHapiNET:masterfrom
AMCN41R:128-XmlCommentRefactor

Conversation

@AMCN41R
Copy link
Collaborator

@AMCN41R AMCN41R commented Jan 28, 2021

  • updated xml comments at the top of each file to use * notation
  • consistent spacing
  • automatic Visual Studio file formatting including removing unused namespaces, organising namespaces and removing unnecessary spaces

@AMCN41R AMCN41R mentioned this pull request Jan 28, 2021
@milkshakeuk
Copy link
Member

milkshakeuk commented Jan 29, 2021

@AMCN41R I know this might be anal but can the comments at the top look like those from the Microsoft documentation?

this

/*
    The main Math class
    Contains all methods for performing basic math functions
*/

instead of this?

/*
*    The main Math class
*    Contains all methods for performing basic math functions
*/

Just trying to make everything as standard as possible. 😎

@milkshakeuk milkshakeuk linked an issue Jan 29, 2021 that may be closed by this pull request
@milkshakeuk milkshakeuk removed a link to an issue Jan 29, 2021
@AMCN41R AMCN41R force-pushed the 128-XmlCommentRefactor branch from f08605a to c801c18 Compare January 29, 2021 11:05
- updated xml comments at the top of each file to use * notation
- consistent spacing
- automatic vs file formatting including removing unused namespaces, organising namespaces and removeing spaces
- Updated licence comment format
@AMCN41R AMCN41R force-pushed the 128-XmlCommentRefactor branch from c801c18 to 073b492 Compare January 29, 2021 11:50
Copy link
Member

@milkshakeuk milkshakeuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMCN41R Looks good!

@milkshakeuk milkshakeuk added this to the v3.0.0.0 milestone Jan 29, 2021
@milkshakeuk milkshakeuk merged commit 0f2ef32 into nHapiNET:master Jan 29, 2021
@milkshakeuk milkshakeuk linked an issue Jan 29, 2021 that may be closed by this pull request
@AMCN41R AMCN41R deleted the 128-XmlCommentRefactor branch January 29, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix XML Build warnings

2 participants