Skip to content

Decouple NHapi source code generation from NHapi.Base#130

Merged
milkshakeuk merged 2 commits intomasterfrom
SourceGenSplit
Jan 27, 2021
Merged

Decouple NHapi source code generation from NHapi.Base#130
milkshakeuk merged 2 commits intomasterfrom
SourceGenSplit

Conversation

@milkshakeuk
Copy link
Member

Closes #127

Update HL7Exception to remove dependency on TableRepository and IHapiLog

Decouple source generation from NHapi.Base

  • Create new project and move source generating source code to it

* Adds enum for ErrorCode, AcknowledgementCode in line with hapi implementation
* Includes unit tests for ErrorCodeExtensions
@milkshakeuk
Copy link
Member Author

@duaneedwards @Usualdosage @ryankelley Could you have a look when you get a second please.

Thanks!

@milkshakeuk
Copy link
Member Author

@duaneedwards @ryankelley @Usualdosage have you guys had any chance to look over this yet?

* Create new project and move source generating source code to it
@milkshakeuk milkshakeuk merged commit 9308e04 into master Jan 27, 2021
@milkshakeuk
Copy link
Member Author

@duaneedwards @Usualdosage @ryankelley
Merged PR since it has been here a while now and no one has had the chance to review.
More than willing to revert if anyone has issues to discuss.

@milkshakeuk milkshakeuk deleted the SourceGenSplit branch January 29, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split out source code generation from Nhapi.Base

1 participant