From 5e6c1d4f4bc049d366dbc9b66d5481f6ed43190e Mon Sep 17 00:00:00 2001 From: Elias Meire Date: Wed, 4 Oct 2023 13:23:33 +0200 Subject: [PATCH] fix(Convert to/from binary data Node): Rename 'Move Binary Data' to 'Convert to/from binary data' (#7318) Github issue / Community forum post (link here to close automatically): --- cypress/e2e/16-webhook-node.cy.ts | 4 ++-- .../nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.json | 3 ++- .../nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.ts | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/cypress/e2e/16-webhook-node.cy.ts b/cypress/e2e/16-webhook-node.cy.ts index c66adb0369013..c32a1407dc565 100644 --- a/cypress/e2e/16-webhook-node.cy.ts +++ b/cypress/e2e/16-webhook-node.cy.ts @@ -187,10 +187,10 @@ describe('Webhook Trigger node', async () => { ndv.getters.backToCanvas().click(); - workflowPage.actions.addNodeToCanvas('Move Binary Data'); + workflowPage.actions.addNodeToCanvas('Convert to/from binary data'); workflowPage.actions.zoomToFit(); - workflowPage.actions.openNode('Move Binary Data'); + workflowPage.actions.openNode('Convert to/from binary data'); cy.getByTestId('parameter-input-mode').click(); getVisibleSelect().find('.option-headline').contains('JSON to Binary').click(); ndv.getters.backToCanvas().click(); diff --git a/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.json b/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.json index 0693d5b238a33..b574ff5aad200 100644 --- a/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.json +++ b/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.json @@ -12,5 +12,6 @@ }, "subcategories": { "Core Nodes": ["Files"] - } + }, + "alias": ["Move Binary Data"] } diff --git a/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.ts b/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.ts index ea9b91d53dca1..e49393e6d12f0 100644 --- a/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.ts +++ b/packages/nodes-base/nodes/MoveBinaryData/MoveBinaryData.node.ts @@ -49,7 +49,7 @@ encodeDecodeOptions.sort((a, b) => { export class MoveBinaryData implements INodeType { description: INodeTypeDescription = { - displayName: 'Move Binary Data', + displayName: 'Convert to/from binary data', name: 'moveBinaryData', icon: 'fa:exchange-alt', group: ['transform'], @@ -57,7 +57,7 @@ export class MoveBinaryData implements INodeType { subtitle: '={{$parameter["mode"]==="binaryToJson" ? "Binary to JSON" : "JSON to Binary"}}', description: 'Move data between binary and JSON properties', defaults: { - name: 'Move Binary Data', + name: 'Convert to/from binary data', color: '#7722CC', }, inputs: ['main'],