Code and test coverage issues

Author: andela-nmartin

server/controllers/documents.js

@@ -56,7 +56,7 @@
            });
          } else {
            if (!document) {
-             res.send({
+             res.status(404).send({
                message: 'No document found.'
              });
            } else {
@@ -103,7 +103,7 @@
            });
          } else {
            if (!document) {
-             res.send({
+             res.status(404).send({
                message: 'No document found.'
              });
            } else {
@@ -116,12 +116,12 @@
                // delete or update
                Document.findOneAndRemove({
                  _id: req.params.id
-               }).exec(function(err, documents) {
+               }).exec(function(err, document) {
                  if (err) {
                    return err;
                  } else {
                    res.status(200).json({
-                     message: documents
+                     message: document
                    });
                  }
                });

server/controllers/roles.js

@@ -23,7 +23,7 @@
       });
       role.save(function(err) {
         if (err) {
-          res.send(err);
+          res.status(409).send(err);
           return;
         }
         res.json({

tests/documents.spec.js

@@ -228,6 +228,48 @@ describe('Administrator Documents', function() {
           }
         });
     });
+
+  it('validates that any users document can be updated by an ' +
+    'Administrator (PUT /api/documents)/:id',
+    function(done) {
+      request
+        .put(url + '/api/documents/' + doc1id)
+        .set('x-access-token', authToken)
+        .send({
+          title: 'Frodo',
+          content: 'A character in LOTR.'
+        })
+        .end(function(err, res) {
+          if (err) {
+            expect(err.status).not.toEqual(200);
+          } else {
+            expect(res.status).toBe(200);
+            expect(typeof res.body).toEqual('object');
+            expect(res.body.success).toBe(true);
+            expect(res.body.message).toBe('Successfully updated Document!');
+          }
+          done();
+        });
+    });
+
+  it('validates that any users document can be deleted by an ' +
+    'Administrator (DELETE /api/documents)/:id',
+    function(done) {
+      request
+        .del(url + '/api/documents/' + doc2id)
+        .set('x-access-token', authToken)
+        .end(function(err, res) {
+          if (err) {
+            expect(err.status).not.toEqual(200);
+          } else {
+            expect(res.status).toEqual(200);
+            expect(typeof res.body).toBe('object');
+            expect(res.body.message.title).toBe(document2.title);
+            expect(res.body.message.content).toBe(document2.content);
+          }
+          done();
+        });
+    });
 });
 // tests for manipulating documents access
 describe('Document tests requiring authentication', function() {
@@ -283,7 +325,7 @@ describe('Document tests requiring authentication', function() {
     'Administrator (DELETE /api/documents)/:id',
     function(done) {
       request
-        .del(url + '/api/documents/' + doc2id)
+        .del(url + '/api/documents/' + doc1id)
         .set('x-access-token', authToken)
         .end(function(err, res) {
           if (err) {

tests/roles.spec.js

@@ -32,12 +32,12 @@ describe('Roles', function() {
         if (err) {
           expect(err.status).not.toEqual(200);
         } else {
-          expect(res.status).toEqual(200);
+          expect(res.status).toEqual(409);
           expect(res.body.code).toEqual(11000);
           expect(res.body.index).toEqual(0);
           expect(res.body.errmsg).toContain('E11000 duplicate key error index');
-          done();
         }
+        done();
       });
   });
 });

tests/users.spec.js

@@ -87,7 +87,7 @@ describe('Users', function() {
       });
   });
 
-  it('validates that a user can be logged in', function(done) {
+  it('validates that a valid user can be logged in', function(done) {
     request
       .post(url + '/api/users/login')
       .send({
@@ -106,4 +106,22 @@ describe('Users', function() {
         }
       });
   });
+
+  it('validates that an invalid user cannot be logged in', function(done) {
+    request
+      .post(url + '/api/users/login')
+      .send({
+        username: 'rupertm',
+        password: '67891'
+      })
+      .end(function(err, res) {
+        if (err) {
+          expect(err.status).not.toEqual(200);
+        } else {
+          expect(res.status).toEqual(500);
+          expect(res.body.message).toBe('User doesnt exist');
+        }
+        done();
+      });
+  });
 });