fix: Endpoint::node_addr completes with direct addrs or relay ready

[Frando]

Description

Currently, Endpoint::node_addr waits for the endpoint's direct addresses to be initialized, and then returns. This is an issue for iroh in the browser, because there we never have direct addresses.

This PR changes the behavior of Endpoint::node_addr so that it completes once either the direct addresses or the home relay URL are initialized.

Breaking Changes

Notes & open questions

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.
• Tests if relevant.
• All breaking changes documented.

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3190/docs/iroh/

Last updated: 2025-02-19T11:47:21Z

[matheus23]

IMHO we could also make node_addr infallible, because all the ? only fail when the Watchers are disconnected. Which should be impossible, given we have a &self reference alive, which holds the respective Watchable at the same time.

If there's errors while getting the home relay or direct addresses, these errors aren't propagated to here anyways - instead it'll fail to resolve :/

---

We should probably also be a little careful with this change and see how much it affects - I hope I don't misremember the history & intention here, I think the intention was to wait for either - and I hope I wasn't wrong 😬

[github-actions]

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 418b10a

[Frando]

One test in iroh needed fixing for this. I am still not totally convinced that this is the right approach. See #3192 for an alternative.