Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node discovery uses wrong detection of when new paths are needed #2621

Open
flub opened this issue Aug 13, 2024 · 1 comment
Open

Node discovery uses wrong detection of when new paths are needed #2621

flub opened this issue Aug 13, 2024 · 1 comment
Labels
bug Something isn't working c-iroh-net

Comments

@flub
Copy link
Contributor

flub commented Aug 13, 2024

DiscoveryTask::needs_discovery uses the NodeInfo::last_received API which is not information that NodeInfo can supply. It is not obvious if it could right now, this needs to be looked at to understand what the condition is really needed for needs_discovery and how to provide this from the PathState and whether (and how) it should be exposed from the more public NodeInfo.

@divagant-martian
Copy link
Contributor

could you add some info on what apis it uses that are wrong and why? if we don't solve the issue soon, by the time we get back to this it will be very hard to remember/understand what's the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c-iroh-net
Projects
Status: No status
Development

No branches or pull requests

2 participants