Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I get a pull request in? #15

Open
wimrijnders opened this issue Oct 16, 2017 · 3 comments
Open

How can I get a pull request in? #15

wimrijnders opened this issue Oct 16, 2017 · 3 comments

Comments

@wimrijnders
Copy link

Hi guys, I've got a PR lined up for the benchmark code, only I can't seem to get a PR going on the timsort github. The method I usually use does not work here. Can you tell me how to do it?

@wimrijnders
Copy link
Author

FYI, in the benchmarks I ran, timsort kicked chromium's ass. Firefox did a better job at resisting, but on the whole it was a technical knockout.

@pineapplemachine
Copy link

bump...

The repo author shows some activity recently. @mziccard - perhaps you could add @wimrijnders @rileyjshaw and/or myself as maintainers? We all seem to have some interest in keeping this project maintained

@wimrijnders
Copy link
Author

@pineapplemachine I'm flattered, but no thanks, I'll pass for maintainership.

I was a maintainer for vis for over a year, and I know how time-consuming it can be. Even if this project is way smaller, I really don't have time too spend on it right now.

I wish you all the best with getting this project going again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants