fix: guard buffer trimming against capture underflow (#432) - #433
Merged
Conversation
An empty block whose render trimmed trailing whitespace could delete text written before the enclosing Capture() started, making the captured region length negative and throwing ArgumentOutOfRangeException. Adjacent empty blockquotes, an empty blockquote between paragraphs, and empty-paragraph list items all hit this. TrimTrailingSpaces now stops at the innermost active capture's start offset.
The converter emits Environment.NewLine, so inline "expected" strings in cases.json (authored with \n) failed on Windows. File-based expectations already get platform endings from the checkout.
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty block whose render trimmed trailing whitespace could delete text written before the enclosing Capture() started, making the captured region length negative and throwing ArgumentOutOfRangeException. Adjacent empty blockquotes, an empty blockquote between paragraphs, and empty-paragraph list items all hit this.
TrimTrailingSpaces now stops at the innermost active capture's start offset.
Fixes #432