-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ingorePath option to the no-unsupported-features
rules
#97
Comments
Thank you for this issue. I'm not sure that the option is needed because I think you can use {
"plugins": ["node"],
"extends": ["eslint:recommended", "plugin:node/recommended"],
"rules": {
},
"overrides": [
{
"files": ["test/**/*.js"],
"rules": {
"node/no-unsupported-features": ["error", { "ignores": ["asyncAwait"] }]
},
}
]
} The |
Ok, it totally makes sense! Thinking more about it, maybe it would be a good idea to add an So in the example of a Node 4 project that uses
The current This is especially true since babel-preset-env is the recommended approach. |
I'm so sorry...I don't know how I missed that.... I'm gonna close the issue as it's irrelevant. Thanks for the help! |
In some cases a project can write both code that will run on Node 4 and code that will be transpiled.
For example ava allow to write test code in es2017.
So for example a project that targets Node 4 will:
"engines": {"node": ">=4"}
in the package.json./index.js
,./src
,./bin
that are supposed to written for Node 4. Those files must be checked../test
that will be transpiled by ava. Those must not be checked.An
ignorePath
option would allow to configure the path to ignore (in this case./test
).In addition it might be a good idea to ignore by default all paths and files not included in the
npm
package (files
properties inpackage.json
+.npmignore
).The text was updated successfully, but these errors were encountered: