Fix: ensures to use absolute path. (refs #13)

Author: mysticatea

lib/util/check-existence.js

@@ -31,8 +31,7 @@ var exists = require("./exists");
  * @returns {void}
  */
 module.exports = function checkForExistence(context, filePath, targets) {
-    var basedir = path.dirname(filePath);
-    var opts = {basedir: basedir};
+    var opts = {basedir: path.dirname(path.resolve(filePath))};
 
     for (var i = 0; i < targets.length; ++i) {
         var target = targets[i];

tests/lib/rules/no-missing-import.js

@@ -136,6 +136,20 @@ ruleTester.run("no-missing-import", rule, {
             code: "export {foo, bar};",
             ecmaFeatures: {modules: true},
             parserOptions: {sourceType: "module"}
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "import eslint from 'eslint'",
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"}
+        },
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "import a from './a';",
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"}
         }
     ],
     invalid: [
@@ -173,6 +187,22 @@ ruleTester.run("no-missing-import", rule, {
             ecmaFeatures: {modules: true},
             parserOptions: {sourceType: "module"},
             errors: ["\"./a.json\" is not found."]
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "import eslint from 'no-exist-package-0';",
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"},
+            errors: ["\"no-exist-package-0\" is not found."]
+        },
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "import c from './c';",
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"},
+            errors: ["\"./c\" is not found."]
         }
     ]
 });

tests/lib/rules/no-missing-require.js

@@ -152,6 +152,18 @@ ruleTester.run("no-missing-require", rule, {
             filename: fixture("test.js"),
             code: "require(`foo${bar}`);",
             env: {node: true, es6: true}
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "require('eslint');",
+            env: {node: true}
+        },
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "require('./a');",
+            env: {node: true}
         }
     ],
     invalid: [
@@ -184,6 +196,20 @@ ruleTester.run("no-missing-require", rule, {
             code: "require('./a.json');",
             env: {node: true},
             errors: ["\"./a.json\" is not found."]
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "require('no-exist-package-0');",
+            env: {node: true},
+            errors: ["\"no-exist-package-0\" is not found."]
+        },
+        {
+            filename: "tests/fixtures/no-missing/test.js",
+            code: "require('./c');",
+            env: {node: true},
+            errors: ["\"./c\" is not found."]
         }
     ]
 });

tests/lib/rules/no-unpublished-import.js

@@ -159,6 +159,20 @@ ruleTester.run("no-unpublished-import", rule, {
             code: "import b from './b';",
             ecmaFeatures: {modules: true},
             parserOptions: {sourceType: "module"}
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "import aaa from 'aaa';",
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"}
+        },
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "import a from './a';",
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"}
         }
     ],
     invalid: [
@@ -231,6 +245,22 @@ ruleTester.run("no-unpublished-import", rule, {
             errors: ["\"../test\" is not published."],
             ecmaFeatures: {modules: true},
             parserOptions: {sourceType: "module"}
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "import noDeps from 'no-deps';",
+            errors: ["\"no-deps\" is not published."],
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"}
+        },
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "import ignore1 from './ignore1';",
+            errors: ["\"./ignore1\" is not published."],
+            ecmaFeatures: {modules: true},
+            parserOptions: {sourceType: "module"}
         }
     ]
 });

tests/lib/rules/no-unpublished-require.js

@@ -175,6 +175,18 @@ ruleTester.run("no-unpublished-require", rule, {
             filename: fixture("1/test.js"),
             code: "require(`foo${bar}`);",
             env: {node: true, es6: true}
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "require('aaa');",
+            env: {node: true}
+        },
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "require('./a');",
+            env: {node: true}
         }
     ],
     invalid: [
@@ -259,6 +271,20 @@ ruleTester.run("no-unpublished-require", rule, {
             options: [{
                 convertPath: {"src/**/*.jsx": ["src/(.+?)\\.jsx", "pub/$1.js"]}
             }]
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "require('no-deps');",
+            errors: ["\"no-deps\" is not published."],
+            env: {node: true}
+        },
+        {
+            filename: "tests/fixtures/no-unpublished/2/test.js",
+            code: "require('./ignore1');",
+            errors: ["\"./ignore1\" is not published."],
+            env: {node: true}
         }
     ]
 });

tests/lib/rules/shebang.js

@@ -91,6 +91,16 @@ ruleTester.run("shebang", rule, {
             filename: fixture("no-bin-field/src/lib/test.js"),
             code: "hello();",
             options: [{"convertPath": {"src/**": ["^src/(.+)$", "$1"]}}]
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/shebang/string-bin/bin/test.js",
+            code: "#!/usr/bin/env node\nhello();"
+        },
+        {
+            filename: "tests/fixtures/shebang/string-bin/lib/test.js",
+            code: "hello();"
         }
     ],
     invalid: [
@@ -193,6 +203,20 @@ ruleTester.run("shebang", rule, {
             output: "hello();",
             options: [{"convertPath": {"src/**": ["^src/(.+)$", "$1"]}}],
             errors: ["This file needs no shebang."]
+        },
+
+        // Should work fine if the filename is relative.
+        {
+            filename: "tests/fixtures/shebang/string-bin/bin/test.js",
+            code: "hello();",
+            output: "#!/usr/bin/env node\nhello();",
+            errors: ["This file needs shebang \"#!/usr/bin/env node\"."]
+        },
+        {
+            filename: "tests/fixtures/shebang/string-bin/lib/test.js",
+            code: "#!/usr/bin/env node\nhello();",
+            output: "hello();",
+            errors: ["This file needs no shebang."]
         }
     ]
 });