BUG#36173373 Fix function/procedure "fetch()" declaration

In TypeScript, properties/fields in a class such as arrow functions
become part of "this" which makes it impossible to call "super" when
overriding those functions in a potential child class.

The most recent versions of the TypeScript compiler actually yield an
error when a method in a parent class is declared with an arrow function
and then is called by a method in the base class.

This patch updates the "fetch()" method declaration in the classes
responsible for handling function and procedure calls (as well as the
base class definition) to avoid bumping into this compiler error.

Change-Id: Ib0f68e8f56dd206bc55ae26531a11914a317bc63

Author: ruiquelhas

gui/extension/CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - BUG#36027690 Connection error when opening REST Object Request Path in Web Browser
 - BUG#36032142 Unexpected error when deleting records with filter containing nullables
+- BUG#36173373 Parent class field not accessible in the child class in the TypeScript SDK
 
 ## Changes in 1.14.2+8.1.1
 

gui/frontend/src/modules/mrs/sdk/MrsBaseClasses.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -1194,7 +1194,7 @@ class MrsBaseObjectCall<I, P extends JsonObject> {
         protected params: P) {
     }
 
-    protected fetch = async (): Promise<I> => {
+    protected async fetch (): Promise<I> {
         const input = `${this.schema.requestPath}${this.requestPath}`;
 
         const res = await this.schema.service.session.doFetch({
@@ -1205,7 +1205,7 @@ class MrsBaseObjectCall<I, P extends JsonObject> {
         });
 
         return await res.json() as I;
-    };
+    }
 }
 
 export class MrsBaseObjectProcedureCall<I, P extends JsonObject>
@@ -1217,11 +1217,11 @@ export class MrsBaseObjectProcedureCall<I, P extends JsonObject>
         super(schema, requestPath, params);
     }
 
-    public fetch = async (): Promise<IMrsProcedureResultList<I>> => {
+    public async fetch (): Promise<IMrsProcedureResultList<I>> {
         const res = await super.fetch();
 
         return res;
-    };
+    }
 }
 
 export class MrsBaseObjectFunctionCall<I, P extends JsonObject> extends MrsBaseObjectCall<I, P> {
@@ -1232,9 +1232,9 @@ export class MrsBaseObjectFunctionCall<I, P extends JsonObject> extends MrsBaseO
         super(schema, requestPath, params);
     }
 
-    public fetch = async (): Promise<I> => {
+    public async fetch (): Promise<I> {
         const res = await super.fetch() as IMrsFunctionResult<I>;
 
         return res.result;
-    };
+    }
 }

mrs_plugin/examples/mrs_notes/src/myService.mrs.sdk/MrsBaseClasses.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -1194,7 +1194,7 @@ class MrsBaseObjectCall<I, P extends JsonObject> {
         protected params: P) {
     }
 
-    protected fetch = async (): Promise<I> => {
+    protected async fetch (): Promise<I> {
         const input = `${this.schema.requestPath}${this.requestPath}`;
 
         const res = await this.schema.service.session.doFetch({
@@ -1205,7 +1205,7 @@ class MrsBaseObjectCall<I, P extends JsonObject> {
         });
 
         return await res.json() as I;
-    };
+    }
 }
 
 export class MrsBaseObjectProcedureCall<I, P extends JsonObject>
@@ -1217,11 +1217,11 @@ export class MrsBaseObjectProcedureCall<I, P extends JsonObject>
         super(schema, requestPath, params);
     }
 
-    public fetch = async (): Promise<IMrsProcedureResultList<I>> => {
+    public async fetch (): Promise<IMrsProcedureResultList<I>> {
         const res = await super.fetch();
 
         return res;
-    };
+    }
 }
 
 export class MrsBaseObjectFunctionCall<I, P extends JsonObject> extends MrsBaseObjectCall<I, P> {
@@ -1232,9 +1232,9 @@ export class MrsBaseObjectFunctionCall<I, P extends JsonObject> extends MrsBaseO
         super(schema, requestPath, params);
     }
 
-    public fetch = async (): Promise<I> => {
+    public async fetch (): Promise<I> {
         const res = await super.fetch() as IMrsFunctionResult<I>;
 
         return res.result;
-    };
+    }
 }

mrs_plugin/sdk/MrsBaseClasses.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -1194,7 +1194,7 @@ class MrsBaseObjectCall<I, P extends JsonObject> {
         protected params: P) {
     }
 
-    protected fetch = async (): Promise<I> => {
+    protected async fetch (): Promise<I> {
         const input = `${this.schema.requestPath}${this.requestPath}`;
 
         const res = await this.schema.service.session.doFetch({
@@ -1205,7 +1205,7 @@ class MrsBaseObjectCall<I, P extends JsonObject> {
         });
 
         return await res.json() as I;
-    };
+    }
 }
 
 export class MrsBaseObjectProcedureCall<I, P extends JsonObject>
@@ -1217,11 +1217,11 @@ export class MrsBaseObjectProcedureCall<I, P extends JsonObject>
         super(schema, requestPath, params);
     }
 
-    public fetch = async (): Promise<IMrsProcedureResultList<I>> => {
+    public async fetch (): Promise<IMrsProcedureResultList<I>> {
         const res = await super.fetch();
 
         return res;
-    };
+    }
 }
 
 export class MrsBaseObjectFunctionCall<I, P extends JsonObject> extends MrsBaseObjectCall<I, P> {
@@ -1232,9 +1232,9 @@ export class MrsBaseObjectFunctionCall<I, P extends JsonObject> extends MrsBaseO
         super(schema, requestPath, params);
     }
 
-    public fetch = async (): Promise<I> => {
+    public async fetch (): Promise<I> {
         const res = await super.fetch() as IMrsFunctionResult<I>;
 
         return res.result;
-    };
+    }
 }