Fix for Bug#98237 (30911870), PREPAREDSTATEMENT.SETOBJECT(I, "FALSE",

TYPES.BOOLEAN) ALWAYS SETS TRUE OR 1.

Author: soklakov

CHANGES

@@ -3,6 +3,8 @@
 
 Version 5.1.49
 
+  - Fix for Bug#98237 (30911870), PREPAREDSTATEMENT.SETOBJECT(I, "FALSE", TYPES.BOOLEAN) ALWAYS SETS TRUE OR 1.
+
   - Fix for Bug#30866178, Not recommended default for 'allowLoadLocalInfile'. Back-port from Bug#94051 (29261254).
 
   - Fix for Bug#30657312, Disable external entities in Fabric's XML parser.

src/com/mysql/jdbc/PreparedStatement.java

@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 2002, 2019, Oracle and/or its affiliates. All rights reserved.
+  Copyright (c) 2002, 2020, Oracle and/or its affiliates. All rights reserved.
 
   The MySQL Connector/J is licensed under the terms of the GPLv2
   <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>, like most MySQL Connectors.
@@ -3682,7 +3682,16 @@ public void setObject(int parameterIndex, Object parameterObj, int targetSqlType
 
                                 break;
                             } else if (parameterObj instanceof String) {
-                                setBoolean(parameterIndex, "true".equalsIgnoreCase((String) parameterObj) || !"0".equalsIgnoreCase((String) parameterObj));
+                                if ("true".equalsIgnoreCase((String) parameterObj) || "Y".equalsIgnoreCase((String) parameterObj)) {
+                                    setBoolean(parameterIndex, true);
+                                } else if ("false".equalsIgnoreCase((String) parameterObj) || "N".equalsIgnoreCase((String) parameterObj)) {
+                                    setBoolean(parameterIndex, false);
+                                } else if (((String) parameterObj).matches("-?\\d+\\.?\\d*")) {
+                                    setBoolean(parameterIndex, !((String) parameterObj).matches("-?[0]+[.]*[0]*"));
+                                } else {
+                                    throw SQLError.createSQLException("No conversion from " + parameterObj + " to Types.BOOLEAN possible.",
+                                            SQLError.SQL_STATE_ILLEGAL_ARGUMENT, getExceptionInterceptor());
+                                }
 
                                 break;
                             } else if (parameterObj instanceof Number) {

src/testsuite/regression/StatementRegressionTest.java

@@ -2260,6 +2260,7 @@ public void testLoadData() throws Exception {
             assertThrows(SQLException.class,
                     versionMeetsMinimum(8, 0, 19) ? "Loading local data is disabled;.*" : "The used command is not allowed with this MySQL version",
                     new Callable<Void>() {
+                        @SuppressWarnings("synthetic-access")
                         public Void call() throws Exception {
                             StatementRegressionTest.this.stmt
                                     .executeUpdate("LOAD DATA LOCAL INFILE '" + fileName + "' INTO TABLE loadDataRegress CHARACTER SET "
@@ -8858,4 +8859,60 @@ public void testBug96442() throws Exception {
 
     }
 
+    /**
+     * Tests fix for Bug#98237 (30911870), PREPAREDSTATEMENT.SETOBJECT(I, "FALSE", TYPES.BOOLEAN) ALWAYS SETS TRUE OR 1.
+     */
+    public void testBug98237() throws Exception {
+        createTable("testBug98237", "(b tinyint)");
+
+        String[] falses = new String[] { "False", "n", "0", "-0", "0.00", "-0.0" };
+        String[] trues = new String[] { "true", "y", "1", "-1", "1.0", "-1.0", "0.01", "-0.01" };
+
+        Properties props = new Properties();
+        boolean useSPS = false;
+        do {
+            props.setProperty("useServerPrepStmts", Boolean.toString(useSPS));
+            Connection con = getConnectionWithProps(props);
+            try {
+                final PreparedStatement ps = con.prepareStatement("insert into testBug98237 values(?)");
+                Statement st = con.createStatement();
+
+                con.createStatement().execute("truncate table testBug98237");
+                for (String val : falses) {
+                    ps.clearParameters();
+                    ps.setObject(1, val, Types.BOOLEAN);
+                    ps.execute();
+                }
+                this.rs = st.executeQuery("select * from testBug98237");
+                for (String val : falses) {
+                    assertTrue(this.rs.next());
+                    assertEquals("'false' was expected for " + val, 0, this.rs.getInt(1));
+                }
+
+                con.createStatement().execute("truncate table testBug98237");
+                for (String val : trues) {
+                    ps.clearParameters();
+                    ps.setObject(1, val, Types.BOOLEAN);
+                    ps.execute();
+                }
+                this.rs = st.executeQuery("select * from testBug98237");
+                for (String val : trues) {
+                    assertTrue(this.rs.next());
+                    assertEquals("'true' was expected for " + val, 1, this.rs.getInt(1));
+                }
+
+                ps.clearParameters();
+                assertThrows(SQLException.class, "No conversion from abc to Types.BOOLEAN possible.", new Callable<Void>() {
+                    public Void call() throws Exception {
+                        ps.setObject(1, "abc", Types.BOOLEAN);
+                        return null;
+                    }
+                });
+
+            } finally {
+                con.close();
+            }
+        } while (useSPS = !useSPS);
+
+    }
 }