Simplify Precision/Scale properties.

Author: bgrainger

src/MySqlConnector/MySql.Data.MySqlClient/MySqlParameter.cs

@@ -53,13 +53,8 @@ public MySqlParameter(string name, MySqlDbType mySqlDbType, int size, ParameterD
 		{
 			Direction = direction;
 			IsNullable = isNullable;
-#if NET45
-			((IDbDataParameter) this).Precision = precision;
-			((IDbDataParameter) this).Scale = scale;
-#else
 			Precision = precision;
 			Scale = scale;
-#endif
 			SourceVersion = sourceVersion;
 			Value = value;
 		}
@@ -104,12 +99,10 @@ public override ParameterDirection Direction
 		public override bool IsNullable { get; set; }
 
 #if NET45
-		byte IDbDataParameter.Precision { get; set; }
-		byte IDbDataParameter.Scale { get; set; }
-#else
-		public override byte Precision { get; set; }
-		public override byte Scale { get; set; }
+#pragma warning disable 109 // no existing member for 'new' to hide
 #endif
+		public new byte Precision { get; set; }
+		public new byte Scale { get; set; }
 
 		public override string ParameterName
 		{

tests/SideBySide/ParameterTests.cs

@@ -1,4 +1,5 @@
 using System.Data;
+using System.Data.Common;
 using MySql.Data.MySqlClient;
 using Xunit;
 
@@ -261,7 +262,7 @@ public void ResetDbType()
 		}
 
 		[Fact]
-		public void Precision()
+		public void PrecisionViaInterface()
 		{
 			IDbCommand command = new MySqlCommand();
 			IDbDataParameter parameter = command.CreateParameter();
@@ -270,12 +271,30 @@ public void Precision()
 		}
 
 		[Fact]
-		public void Scale()
+		public void PrecisionViaBaseClass()
+		{
+			DbCommand command = new MySqlCommand();
+			DbParameter parameter = command.CreateParameter();
+			parameter.Precision = 11;
+			Assert.Equal((byte) 11, parameter.Precision);
+		}
+
+		[Fact]
+		public void ScaleViaInterface()
 		{
 			IDbCommand command = new MySqlCommand();
 			IDbDataParameter parameter = command.CreateParameter();
 			parameter.Scale = 12;
 			Assert.Equal((byte) 12, parameter.Scale);
 		}
+
+		[Fact]
+		public void ScaleViaBaseClass()
+		{
+			DbCommand command = new MySqlCommand();
+			DbParameter parameter = command.CreateParameter();
+			parameter.Scale = 12;
+			Assert.Equal((byte) 12, parameter.Scale);
+		}
 	}
 }