Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document or deprecate and hide Row.show #217

Open
schveiguy opened this issue Feb 20, 2020 · 1 comment
Open

Document or deprecate and hide Row.show #217

schveiguy opened this issue Feb 20, 2020 · 1 comment
Milestone

Comments

@schveiguy
Copy link
Collaborator

There is an undocumented but public function in Row called show. If it is intended only for debugging, it should be switched to package or private. If it is intended for public consumption it should be documented.

@Abscissa
Copy link

This is another one of the things that predates my involvement. Not sure offhand if it's from Steve Teale's, but its definitely been in there ages.

I'd say it should definitely be changed to private (definitely looks more debugging to me and not ideal for public). But that's technically a breaking change so it should coincide with one of our bigger semver version bumps.

@schveiguy schveiguy added this to the 4.0.0 milestone Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants