HV-921 Precompile patterns for meta character replacements

Author: dernasherbrezon

engine/src/main/java/org/hibernate/validator/messageinterpolation/AbstractMessageInterpolator.java

@@ -23,6 +23,8 @@
 import java.util.Locale;
 import java.util.MissingResourceException;
 import java.util.ResourceBundle;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
 
 import javax.validation.MessageInterpolator;
 import javax.xml.bind.ValidationException;
@@ -110,6 +112,11 @@ public abstract class AbstractMessageInterpolator implements MessageInterpolator
 	 */
 	private final boolean cachingEnabled;
 
+	private static final Pattern LEFT_BRACE = Pattern.compile("\\{", Pattern.LITERAL);
+	private static final Pattern RIGHT_BRACE = Pattern.compile("\\}", Pattern.LITERAL);
+	private static final Pattern SLASH = Pattern.compile("\\\\", Pattern.LITERAL);
+	private static final Pattern DOLLAR = Pattern.compile("\\$", Pattern.LITERAL);
+
 	public AbstractMessageInterpolator() {
 		this( null );
 	}
@@ -299,10 +306,10 @@ private String interpolateMessage(String message, Context context, Locale locale
 	}
 
 	private String replaceEscapedLiterals(String resolvedMessage) {
-		resolvedMessage = resolvedMessage.replace( "\\{", "{" );
-		resolvedMessage = resolvedMessage.replace( "\\}", "}" );
-		resolvedMessage = resolvedMessage.replace( "\\\\", "\\" );
-		resolvedMessage = resolvedMessage.replace( "\\$", "$" );
+		resolvedMessage = LEFT_BRACE.matcher(resolvedMessage).replaceAll("{");
+		resolvedMessage = RIGHT_BRACE.matcher(resolvedMessage).replaceAll("}");
+		resolvedMessage = SLASH.matcher(resolvedMessage).replaceAll(Matcher.quoteReplacement("\\"));
+		resolvedMessage = DOLLAR.matcher(resolvedMessage).replaceAll(Matcher.quoteReplacement("$"));
 		return resolvedMessage;
 	}