You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 28, 2020. It is now read-only.
Three fields which are currently in SiteSettings shouldn't be - they're used by core Django, so we can't easily modify that code to use a value from SiteSettings instead:
DEFAULT_FROM_EMAIL
SERVER_EMAIL
DATE_FORMAT
These should be removed from SiteSettings.
The following remaining settings are OK to handle as values of SiteSettings, but I've spotted many instances in the code when their value from django.conf.settings is used instead of SiteSettings - these all need to be checked, and any wrong ones fixed:
SITE_OWNER
SITE_OWNER_URL
COPYRIGHT_HOLDER
TWITTER_USERNAME
SUPPORT_EMAIL
DD_MM_DATE_FORMAT_PREFERRED
MAPIT_BASE_URL
GOOGLE_ANALYTICS_ACCOUNT
USE_UNIVERSAL_ANALYTICS
NEW_ACCOUNTS_ALLOWED
HOIST_ELECTED_CANDIDATES
RESTRICT_RENAMES
EDITS_ALLOWED
CANDIDATES_REQUIRED_FOR_WEIGHTED_PARTY_LIST
TWITTER_APP_ONLY_BEARER_TOKEN
IMAGE_PROXY_URL
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Three fields which are currently in SiteSettings shouldn't be - they're used by core Django, so we can't easily modify that code to use a value from SiteSettings instead:
DEFAULT_FROM_EMAIL
SERVER_EMAIL
DATE_FORMAT
These should be removed from
SiteSettings
.The following remaining settings are OK to handle as values of
SiteSettings
, but I've spotted many instances in the code when their value fromdjango.conf.settings
is used instead ofSiteSettings
- these all need to be checked, and any wrong ones fixed:SITE_OWNER
SITE_OWNER_URL
COPYRIGHT_HOLDER
TWITTER_USERNAME
SUPPORT_EMAIL
DD_MM_DATE_FORMAT_PREFERRED
MAPIT_BASE_URL
GOOGLE_ANALYTICS_ACCOUNT
USE_UNIVERSAL_ANALYTICS
NEW_ACCOUNTS_ALLOWED
HOIST_ELECTED_CANDIDATES
RESTRICT_RENAMES
EDITS_ALLOWED
CANDIDATES_REQUIRED_FOR_WEIGHTED_PARTY_LIST
TWITTER_APP_ONLY_BEARER_TOKEN
IMAGE_PROXY_URL
The text was updated successfully, but these errors were encountered: