Skip to content

Need a better solution not to include PJON lib into MySensors repo #1516

Open
@virtual-maker

Description

@virtual-maker

There are two main problems with the newly included PJON library:

  1. The addition seems to break the CI and let always fail the "Toll gate" step.
  2. The included PJON library is practically a fork which makes it difficulty to sync it with the original PJON lib.

Current discussion:

  • "I personally dislike the idea to include this big external PJON library into the MySensors lib repo. May be an other solution by use of an external library reference would be better."

  • "The Arduino IDE does not handle dependencies (at least not in an useful way). This has caused a lot of problems for MySensors users. The least bad way we’ve found so far is to include all code in the same repo. But that also means that we in effect fork every dependency, which sucks."

  • "I’m not sure how we should handle the PJON case. I’ll think about it and see if there is something I think could work better."

Ideas and suggestions are very welcome.

Originally posted by @mfalkvidd in #1515 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions