Skip to content

Commit 2a308c5

Browse files
committed
suggested refactor
1 parent 8c18214 commit 2a308c5

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

java-strings/src/main/java/com/baeldung/string/MatchWords.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ public class MatchWords {
1515
public static boolean containsWordsIndexOf(String inputString, String[] words) {
1616
boolean found = true;
1717
for (String word : words) {
18-
int index = inputString.indexOf(word);
19-
if (index == -1) {
18+
if (inputString.indexOf(word) == -1) {
2019
found = false;
2120
break;
2221
}
@@ -64,21 +63,19 @@ public static boolean containsWordsPatternMatch(String inputString, String[] wor
6463
}
6564

6665
Pattern pattern = Pattern.compile(regexp.toString());
67-
if (pattern.matcher(inputString).find()) {
68-
return true;
69-
}
70-
return false;
66+
67+
return pattern.matcher(inputString).find();
7168
}
7269

7370
public static boolean containsWordsJava8(String inputString, String[] words) {
74-
List inputStringList = Arrays.asList(inputString.split(" "));
71+
List<String> inputStringList = Arrays.asList(inputString.split(" "));
7572
List<String> wordsList = Arrays.asList(words);
7673

7774
return wordsList.stream().allMatch(inputStringList::contains);
7875
}
7976

8077
public static boolean containsWordsArray(String inputString, String[] words) {
81-
List inputStringList = Arrays.asList(inputString.split(" "));
78+
List<String> inputStringList = Arrays.asList(inputString.split(" "));
8279
List<String> wordsList = Arrays.asList(words);
8380

8481
return inputStringList.containsAll(wordsList);

0 commit comments

Comments
 (0)