Update copyright notices and improve code quality

BenjaminAbt · BenjaminAbt · commit db923681c000 · 2025-04-13T13:09:24.000+02:00
This commit updates copyright comments across multiple files to include a complete URL for the copyright holder. It also enhances type safety and readability by changing variable types and using nullable reference types. The indentation size in the `.editorconfig` file has been changed from 4 to 2, affecting code formatting. Additionally, test files have been updated to use shorthand syntax for initializing `HeaderDictionary`. These changes aim to improve code quality, consistency, and adherence to modern C# practices.
diff --git a/.editorconfig b/.editorconfig
@@ -122,6 +122,7 @@ indent_size = 2
 # Code files
 [*.{cs,csx,vb,vbx}]
 indent_size = 4
+file_header_template = Copyright © https://myCSharp.de - all rights reserved
 
 # Organize usings
 dotnet_sort_system_directives_first = true
diff --git a/samples/HttpClientHints.Samples.AspNetCoreMvc/Controllers/HomeController.cs b/samples/HttpClientHints.Samples.AspNetCoreMvc/Controllers/HomeController.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.AspNetCore.Mvc;
 
diff --git a/samples/HttpClientHints.Samples.AspNetCoreMvc/Program.cs b/samples/HttpClientHints.Samples.AspNetCoreMvc/Program.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using MyCSharp.HttpClientHints.AspNetCore;
 
diff --git a/src/HttpClientHints.AspNetCore/HttpClientHintsHttpContextExtensions.cs b/src/HttpClientHints.AspNetCore/HttpClientHintsHttpContextExtensions.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Primitives;
@@ -23,13 +23,13 @@ public static class HttpClientHintsHttpContextExtensions
     public static HttpClientHints GetClientHints(this HttpContext context)
     {
         // Check if client hints are already cached for this request
-        if (context.Items.TryGetValue(ClientHintsCacheKey, out var cached) && cached is HttpClientHints hints)
+        if (context.Items.TryGetValue(ClientHintsCacheKey, out object? cached) && cached is HttpClientHints hints)
         {
             return hints;
         }
-        
+
         // Create and cache new client hints
-        var newHints = context.Request.Headers.GetClientHints();
+        HttpClientHints newHints = context.Request.Headers.GetClientHints();
         context.Items[ClientHintsCacheKey] = newHints;
         return newHints;
     }
@@ -44,14 +44,14 @@ public static HttpClientHints GetClientHints(this IHeaderDictionary headers)
         // User Agent
         headers.TryGetValue("User-Agent", out StringValues userAgentValues);
         string? userAgent = userAgentValues.Count > 0 ? userAgentValues[0] : null;
-        
+
         headers.TryGetValue("Sec-CH-UA", out StringValues uaValues);
         string? ua = uaValues.Count > 0 ? uaValues[0] : null;
 
         // Platform
         headers.TryGetValue("Sec-CH-UA-Platform", out StringValues platformValues);
         string? platform = platformValues.Count > 0 ? platformValues[0] : null;
-        
+
         headers.TryGetValue("Sec-CH-UA-Platform-Version", out StringValues platformVersionValues);
         string? platformVersion = platformVersionValues.Count > 0 ? platformVersionValues[0] : null;
 
@@ -66,7 +66,7 @@ public static HttpClientHints GetClientHints(this IHeaderDictionary headers)
         // Device
         headers.TryGetValue("Sec-CH-UA-Model", out StringValues modelValues);
         string? model = modelValues.Count > 0 ? modelValues[0] : null;
-        
+
         headers.TryGetValue("Sec-CH-UA-Mobile", out StringValues mobileValues);
         bool? mobile = HttpClientHintsInterpreter.IsMobile(mobileValues.Count > 0 ? mobileValues[0] : null);
 
diff --git a/src/HttpClientHints.AspNetCore/HttpClientHintsMiddlewareConfig.cs b/src/HttpClientHints.AspNetCore/HttpClientHintsMiddlewareConfig.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 namespace MyCSharp.HttpClientHints.AspNetCore;
 
diff --git a/src/HttpClientHints.AspNetCore/HttpClientHintsOptions.cs b/src/HttpClientHints.AspNetCore/HttpClientHintsOptions.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 namespace MyCSharp.HttpClientHints.AspNetCore;
 
diff --git a/src/HttpClientHints.AspNetCore/HttpClientHintsRegistration.cs b/src/HttpClientHints.AspNetCore/HttpClientHintsRegistration.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
diff --git a/src/HttpClientHints.AspNetCore/HttpClientHintsRequestMiddleware.cs b/src/HttpClientHints.AspNetCore/HttpClientHintsRequestMiddleware.cs
@@ -1,3 +1,5 @@
+// Copyright � https://myCSharp.de - all rights reserved
+
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Options;
 
diff --git a/src/HttpClientHints/HttpClientHints.cs b/src/HttpClientHints/HttpClientHints.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.Extensions.Primitives;
 
diff --git a/src/HttpClientHints/HttpClientHintsInterpreter.cs b/src/HttpClientHints/HttpClientHintsInterpreter.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 namespace MyCSharp.HttpClientHints;
 
diff --git a/tests/HttpClientHints.AspNetCore.UnitTests/HttpClientHintsHttpContextExtensionsTests.cs b/tests/HttpClientHints.AspNetCore.UnitTests/HttpClientHintsHttpContextExtensionsTests.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Primitives;
@@ -12,7 +12,7 @@ public class HttpClientHintsHttpContextExtensionsTests
     public void GetClientHints_ReturnsCorrectValues_WhenHeadersArePresent()
     {
         // Arrange
-        HeaderDictionary headers = new HeaderDictionary
+        HeaderDictionary headers = new()
         {
             { "User-Agent", new StringValues("TestUserAgent") },
             { "Sec-CH-UA", new StringValues("TestUA") },
@@ -65,7 +65,7 @@ public void GetClientHints_ReturnsNullValues_WhenHeadersAreMissing()
     public void GetClientHints_ReturnsCorrectMobileValue_WhenMobileHeaderIsTrue()
     {
         // Arrange
-        HeaderDictionary headers = new HeaderDictionary
+        HeaderDictionary headers = new()
         {
             { "Sec-CH-UA-Mobile", new StringValues("?1") } // true
         };
@@ -81,7 +81,7 @@ public void GetClientHints_ReturnsCorrectMobileValue_WhenMobileHeaderIsTrue()
     public void GetClientHints_ReturnsCorrectMobileValue_WhenMobileHeaderIsFalse()
     {
         // Arrange
-        HeaderDictionary headers = new HeaderDictionary
+        HeaderDictionary headers = new()
         {
             { "Sec-CH-UA-Mobile", new StringValues("?0") } // false
         };
diff --git a/tests/HttpClientHints.AspNetCore.UnitTests/HttpClientHintsRegistrationTests.cs b/tests/HttpClientHints.AspNetCore.UnitTests/HttpClientHintsRegistrationTests.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
diff --git a/tests/HttpClientHints.AspNetCore.UnitTests/HttpClientHintsRequestMiddlewareTests.cs b/tests/HttpClientHints.AspNetCore.UnitTests/HttpClientHintsRequestMiddlewareTests.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Options;
diff --git a/tests/HttpClientHints.UnitTests/HttpClientHintsInterpreterTests.cs b/tests/HttpClientHints.UnitTests/HttpClientHintsInterpreterTests.cs
@@ -1,4 +1,4 @@
-// Copyright © myCSharp.de - all rights reserved
+// Copyright © https://myCSharp.de - all rights reserved
 
 using Xunit;
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Copyright © myCSharp.de - all rights reserved`
	`1`	`+// Copyright © https://myCSharp.de - all rights reserved`
`2`	`2`
`3`	`3`	`using Microsoft.AspNetCore.Mvc;`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+// Copyright © https://myCSharp.de - all rights reserved`
	`2`	`+`
`1`	`3`	`using Microsoft.AspNetCore.Http;`
`2`	`4`	`using Microsoft.Extensions.Options;`
`3`	`5`