Fix copying of DateTimeZone objects (#86)

Closes #70.

Author: theofidry

fixtures/f007/FooDateTimeZone.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace DeepCopy\f007;
+
+use DateTimeZone;
+
+class FooDateTimeZone extends DateTimeZone
+{
+    public $cloned = false;
+
+    public function __clone()
+    {
+        $this->cloned = true;
+    }
+}

src/DeepCopy/DeepCopy.php

@@ -3,15 +3,17 @@
 namespace DeepCopy;
 
 use DateTimeInterface;
+use DateTimeZone;
 use DeepCopy\Exception\CloneException;
 use DeepCopy\Filter\Filter;
 use DeepCopy\Matcher\Matcher;
-use DeepCopy\TypeFilter\Spl\SplDoublyLinkedList;
+use DeepCopy\TypeFilter\Spl\SplDoublyLinkedListFilter;
 use DeepCopy\TypeFilter\TypeFilter;
 use DeepCopy\TypeMatcher\TypeMatcher;
 use ReflectionObject;
 use ReflectionProperty;
 use DeepCopy\Reflection\ReflectionHelper;
+use SplDoublyLinkedList;
 
 /**
  * @final
@@ -55,7 +57,7 @@ public function __construct($useCloneMethod = false)
     {
         $this->useCloneMethod = $useCloneMethod;
 
-        $this->addTypeFilter(new SplDoublyLinkedList($this), new TypeMatcher('SplDoublyLinkedList'));
+        $this->addTypeFilter(new SplDoublyLinkedListFilter($this), new TypeMatcher(SplDoublyLinkedList::class));
     }
 
     /**
@@ -184,7 +186,7 @@ private function copyObject($object)
             return $newObject;
         }
 
-        if ($newObject instanceof DateTimeInterface) {
+        if ($newObject instanceof DateTimeInterface || get_class($newObject) === DateTimeZone::class) {
             return $newObject;
         }
 

tests/DeepCopyTest/DeepCopyTest.php

@@ -4,6 +4,7 @@
 
 use DateTime;
 use DateTimeImmutable;
+use DateTimeZone;
 use DeepCopy\DeepCopy;
 use DeepCopy\Exception\CloneException;
 use DeepCopy\f001;
@@ -132,18 +133,35 @@ public function test_dynamic_properties_are_copied()
 
     /**
      * @ticket https://github.com/myclabs/DeepCopy/issues/38
+     * @ticket https://github.com/myclabs/DeepCopy/pull/70
      */
     public function test_it_can_copy_an_object_with_a_date_object_property()
     {
         $object = new stdClass();
 
         $object->d1 = new DateTime();
         $object->d2 = new DateTimeImmutable();
+        $object->dtz = new DateTimeZone('UTC');
 
         $copy = deep_copy($object);
 
         $this->assertEqualButNotSame($object->d1, $copy->d1);
         $this->assertEqualButNotSame($object->d2, $copy->d2);
+        $this->assertEqualButNotSame($object->dtz, $copy->dtz);
+    }
+
+    /**
+     * @ticket https://github.com/myclabs/DeepCopy/pull/70g
+     */
+    public function test_it_does_not_skip_the_copy_for_userland_datetimezone()
+    {
+        $object = new stdClass();
+
+        $object->dtz = new DateTimeZone('UTC');
+
+        $copy = deep_copy($object);
+
+        $this->assertEqualButNotSame($object->dtz, $copy->dtz);
     }
 
     public function test_it_copies_the_private_properties_of_the_parent_class()