#3028 Add shaded javassist package to osgi.export

[mpiggott]

#3028 NoClassDefFoundExceptions on Java 11 with OSGi

On Java 11 using Karaf with Felix when enhancing classes users need access to:

• org.apache.ibatis.executor.loader.WriteReplaceInterface
• org.apache.ibatis.javassist.util.proxy.ProxyObject

In the current build the bnd-maven-plugin is executed before shading thus the Javassist classes don't exist and aren't exported. In my local build bnd passed with this addition and I was able to use the SNAPSHOT bundle in my application successfully

[hazendaz]

@mpiggott Would it be better if we got the order of plugins running correctly? Doing so is relatively easy. We would need a dummy place holder for the plugin in the build pom commented as to why we redefined it (assuming its not defined now) and for that to be listed after shade. My gut tells me the order issue is due to our parent and how maven resolves things. I'm fine either way just wondered if that would be more direct fix.

[coveralls]

coverage: 86.597% (-0.009%) from 86.606%
when pulling 7bbf191 on mpiggott:master
into 5eefb8c on mybatis:master.

[mpiggott]

@hazendaz both plugins appear to be bound by default to the package phase. I don't recall how maven chooses the order so I tried locally ensuring the defined order in the pom was shade -> bnd but the result was the same. There is a PREPARE_PACKAGE phase also but I'm not sure whether that ends up conflicting with other plugins.

[hazendaz]

Hi @mpiggott thanks, glad that you tried that at least. I would have expected it to change but it does get messy with a parent pom, plugin management, etc. Will go ahead and take this change. We are working on a few other things with our build process in general so not sure on ETA on release as we had just done one but will discuss with team and let you know.

[hazendaz]

I am surprised ognl doesn't have same issue here since we shade that too.