Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Rework test process and document it dropping use of prioer profile for straight property usage #2820

Merged
merged 9 commits into from
Feb 20, 2023

Conversation

hazendaz
Copy link
Member

…readable

@hazendaz hazendaz self-assigned this Feb 20, 2023
@coveralls
Copy link

coveralls commented Feb 20, 2023

Coverage Status

Coverage: 87.51% (-0.009%) from 87.52% when pulling 5a46b2e on hazendaz:tests into 4f04806 on mybatis:master.

@hazendaz hazendaz requested a review from harawata February 20, 2023 20:19
@hazendaz
Copy link
Member Author

@harawata I had made this change in the parent some time ago. Had this sitting around and not pushed so switching over. Odd behavior though is that before this had 1765 ubuntu tests run at jdk 11. Now it is 1730. I added a few extra helpers now so we know what profiles are active. Everything looks right. All other tests run expected numbers. The active profiles are correct.

Would you happen to have any idea what might be the issue? Presumably 'excludedGroups' is acting different.

Here is profile from the parent

    <profile>
      <!-- Run slow tests only on CI ONLY, to force run otherwise use -D"env.CI_ONLY_TEST_GROUPS" -->
      <id>ci-only</id>
      <activation>
        <property>
          <name>env.CI_ONLY_TEST_GROUPS</name>
        </property>
      </activation>
      <properties>
        <excludedGroups />
      </properties>
    </profile>

In the parent it defines excludedGroups as

<excludedGroups />

I suspect a resolution different due to parent controlling now. And maybe our GH actions for CI is just wrongly setup. The default exclusion in mybatis-3 is TestcontainersTests.

… set excludedGroups

profile is not needed.  All we are doing is setting a property.
@hazendaz
Copy link
Member Author

trying to not have profile at all as it seems unnecessary based on how all the other setup is working...

@hazendaz
Copy link
Member Author

@harawata ok resolved another way here. Got rid of using the profile all together. That seems to do the trick.

@hazendaz hazendaz changed the title [pom] Move surefire configuration to parent and make properties more … [tests] Rework test process and document it dropping use of prioer profile for straight property usage Feb 20, 2023
@hazendaz hazendaz merged commit ee23508 into mybatis:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants