Skip to content

Commit db754ce

Browse files
authored
Merge pull request #2805 from hogimn/test
Update test code to clarify the consequence
2 parents 661e574 + b2bc913 commit db754ce

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/test/java/org/apache/ibatis/executor/BaseExecutorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,10 @@ void shouldSelectDiscriminatedPost() throws Exception {
253253
for (Map<String, String> m : products) {
254254
if ("IMAGES".equals(m.get("SECTION"))) {
255255
assertNull(m.get("subject"));
256+
assertNotNull(m.get("id"));
256257
} else {
257258
assertNotNull(m.get("subject"));
259+
assertNull(m.get("id"));
258260
}
259261
}
260262
} finally {
@@ -274,8 +276,10 @@ void shouldSelect2DiscriminatedPosts() throws Exception {
274276
for (Map<String, String> m : products) {
275277
if ("IMAGES".equals(m.get("SECTION"))) {
276278
assertNull(m.get("subject"));
279+
assertNotNull(m.get("id"));
277280
} else {
278281
assertNotNull(m.get("subject"));
282+
assertNull(m.get("id"));
279283
}
280284
}
281285
} finally {

src/test/java/org/apache/ibatis/executor/ExecutorTestHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ static MappedStatement prepareSelectDiscriminatedPost(final Configuration config
305305
put("NEWS", discriminatorResultMap.getId());
306306
put("VIDEOS", discriminatorResultMap.getId());
307307
put("PODCASTS", discriminatorResultMap.getId());
308-
// NEWS left out on purpose.
308+
// IMAGES left out on purpose.
309309
}
310310
}).build()).build());
311311

0 commit comments

Comments
 (0)