Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--pre-commit mode should add the generated text files to the commit #200

Closed
mwouts opened this issue Mar 15, 2019 · 1 comment
Closed

--pre-commit mode should add the generated text files to the commit #200

mwouts opened this issue Mar 15, 2019 · 1 comment
Milestone
1.0.4

Comments

@mwouts
Copy link
Owner

mwouts commented Mar 15, 2019

This was reported by @jainr at #142 .

We will have to

  • Improve the test and make sure that the py file is not only created, but also added to the commit
  • Fix the test, probably through a modification of this function
  • And explicitly cover @jainr's usage with a test. His pre-commit hook is
jupytext --from ipynb --to python//py:light --pre-commit
@mwouts mwouts mentioned this issue Mar 15, 2019
Closed
@mwouts mwouts added this to the 1.0.4 milestone Mar 18, 2019
mwouts added a commit that referenced this issue Mar 19, 2019
@mwouts
The pre-commit hook must add the result of conversion to the commit
bf1f8fb 
Fix #200
@mwouts mwouts mentioned this issue Mar 19, 2019
Merged
@mwouts mwouts closed this as completed in 3d1c956 Mar 20, 2019
@mwouts
Copy link
Owner Author

mwouts commented Mar 20, 2019

The fix is available in version 1.0.4. @jainr, can you confirm that it now works as expected? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
1 participant
@mwouts