-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming notebook bug #190
Comments
Hi @Atcold . What happens here is that Jupyter only knows about the pairing information once it has opened the notebook. One way to correct what you see would be to have the Jupytext contents manager open a notebook before renaming it, but maybe that's too much for a simple renaming operation? |
Hmm, I'm providing user feedback. Meaning, I'm trying to use the software / plug-in, and report unexpected behaviour. Is there a way to wrap Jupyter's renaming function adding the additional file renaming? |
@Atcold , we can achieve the desired behavior with this simple change: fdc32ea. With this change, Jupytext would read the notebook and extract the pairing information before renaming it. Do you confirm the convenience of renaming files in pairs is worth the potentially large time required to read the notebook? |
@mwouts, I think renaming is not a frequent operation. Therefore, its longer execution time would go unnoticed, IMHO. Furthermore, faster renaming can still be achieved by using a command line. |
I agree - we will include this in the next release. |
Available in version 1.0.2 |
If I select a notebook (in the Home interface of Jupyter) and click on rename, the associated
py
won't be renamed.Renaming an open notebook by clicking on the header, where the name is located, instead does work.
The text was updated successfully, but these errors were encountered: