Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI overwrites without warning #113

Closed
dsblank opened this issue Oct 25, 2018 · 3 comments
Closed

CLI overwrites without warning #113

dsblank opened this issue Oct 25, 2018 · 3 comments
Labels
good first issue Good for newcomers

Comments

@dsblank
Copy link
Contributor

dsblank commented Oct 25, 2018

If I call the CLI to output a particular format, it will overwrite existing file named the same.

Suggestions:

  1. give a warning that it overwrote file
  2. require a --force flag to overwrite
  3. put a unique number on new file

In general, it would be nice for the CLI to give some feedback about what it read in, and what it created.

@mwouts
Copy link
Owner

mwouts commented Oct 25, 2018

Hello @dsblank , thanks for reporting. When I compare with jupyter nbconvert is see that nbconvert also overrides the output file. Sure, this can be a surprise to the user, but this is a CLI, isn't it?

I agree that the CLI could tell a bit more about what it is doing (format detected in the file, output file, format, whever it tries to preserve outputs, etc). Would you like to submit a PR (on v0.8.4 if possible)? Please keep in mind that people may be using the command line to convert document in batches, and may also pipe notebooks into it (stdin and stdout are supported).

@mwouts mwouts added the good first issue Good for newcomers label Oct 25, 2018
@dsblank
Copy link
Contributor Author

dsblank commented Oct 25, 2018

Sure, I'll try to look at this in the next few days (unless someone beats me to it). Thanks!

@mwouts
Copy link
Owner

mwouts commented Oct 29, 2018

Available in v0.8.4

@mwouts mwouts closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants