Skip to content

Commit

Permalink
Default value for as_version is nbformat's one
Browse files Browse the repository at this point in the history
  • Loading branch information
mwouts committed Sep 1, 2019
1 parent 8ebf94b commit a4655ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Release History
- Documented how to use Jupytext as a Python library (#317)
- Mention of the server extension in the documentation (#304)
- Test a `README.md` is as simple as `jupytext --execute README.md` (#303)
- The default value of `as_version` in `jupytext.read` is `nbformat.NO_CONVERT`, as for `nbformat.read`

**BugFixes**

Expand Down
4 changes: 2 additions & 2 deletions jupytext/jupytext.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def writes(self, nb, metadata=None, **kwargs):
return '\n'.join(header + lines)


def reads(text, fmt, as_version=4, **kwargs):
def reads(text, fmt, as_version=nbformat.NO_CONVERT, **kwargs):
"""
Read a notebook from a string
Expand Down Expand Up @@ -227,7 +227,7 @@ def reads(text, fmt, as_version=4, **kwargs):
return notebook


def read(fp, as_version=4, fmt=None, **kwargs):
def read(fp, as_version=nbformat.NO_CONVERT, fmt=None, **kwargs):
""""
Read a notebook from a file name or a file object
Expand Down

0 comments on commit a4655ad

Please sign in to comment.