Skip to content

Conversation

@jtpio
Copy link

@jtpio jtpio commented Dec 8, 2025

As discussed in jupyterlab/hatch-jupyter-builder#146, the new hatch>=1.16 seems to be requiring this change.

This reverts parts of #455

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (3f6f154) to head (ebf348b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          43       43           
  Lines        1891     1891           
=======================================
  Hits         1770     1770           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwouts
Copy link
Owner

mwouts commented Dec 8, 2025

Hi @jtpio , thank you for the PR! I wanted to give it a try but you've been faster.

If I read the output of the build step correctly we seem to reach a different error now - dash-generate-components: not found. It sounds likely that I have not been explicit re the need to have dash when the package is build, I will have a look soon (possibly over the next week-end). At least the jupyter-builder hook can be found now!

NB: Re the other errors I think you will just have to run pixi lock following the change on pyproject.toml.

@jtpio
Copy link
Author

jtpio commented Dec 8, 2025

While this may help fix the issue for now, it still looks like something that should be fixed elsewhere, either in hatch-jupyter-builder or in hatch directly: pypa/hatch#2110 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants