Ignore w:u elements when w:val is missing

Author: mwilliamson

NEWS

@@ -9,6 +9,8 @@
 * Emit warning instead of throwing exception when image file cannot be found for
   a:blip elements.
 
+* Ignore w:u elements when w:val is missing.
+
 # 1.4.2
 
 * Support soft hyphens.

src/main/java/org/zwobble/mammoth/internal/docx/StatefulBodyXmlReader.java

@@ -209,7 +209,7 @@ private boolean isUnderline(XmlElementLike properties) {
         return properties.findChild("w:u")
             .map(child -> child.getAttributeOrNone("w:val")
                 .map(value -> !value.equals("false") && !value.equals("0") && !value.equals("none"))
-                .orElse(true))
+                .orElse(false))
             .orElse(false);
     }
 

src/test/java/org/zwobble/mammoth/tests/docx/BodyXmlTests.java

@@ -579,12 +579,12 @@ public void runIsNotUnderlinedIfUnderlineElementIsNotPresent() {
     }
 
     @Test
-    public void runIsUnderlinedIfUnderlineElementIsPresentWithoutValAttribute() {
+    public void runIsNotUnderlinedIfUnderlineElementIsPresentWithoutValAttribute() {
         XmlElement element = runXmlWithProperties(element("w:u"));
 
         assertThat(
             readSuccess(bodyReader(), element),
-            hasProperty("underline", equalTo(true))
+            hasProperty("underline", equalTo(false))
         );
     }