SONARJAVA-2554 Update rule description and metadata

Author: benzonico

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1166_java.html

@@ -60,5 +60,6 @@ <h2>Exceptions</h2>
 <h2>See</h2>
 <ul>
   <li> <a href="https://www.securecoding.cert.org/confluence/x/6gEqAQ">CERT, ERR00-J.</a> - Do not suppress or ignore checked exceptions </li>
+  <li> OWASP Top 10 2017 Category A10 - Insufficient Logging &amp; Monitoring </li>
 </ul>
 

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1166_java.json

@@ -8,6 +8,7 @@
   },
   "tags": [
     "error-handling",
+    "owasp-a10",
     "cert",
     "suspicious"
   ],

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1176_java.html

@@ -9,7 +9,7 @@
 </ul>
 <p>Furthermore the following guidelines should be followed:</p>
 <ul>
-  <li> At least 1 line of description which should have more than one word. </li>
+  <li> At least 1 line of description. </li>
   <li> All parameters documented with <code>@param</code>, and names should match. </li>
   <li> All checked exceptions documented with <code>@throws</code> </li>
   <li> <code>@return</code> present and documented when not <code>void</code>. </li>

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1212_java.html

@@ -4,10 +4,10 @@
 <h2>Noncompliant Code Example</h2>
 <pre>
 public void doTheThing(String str, int i, List&lt;String&gt; strings) {
-  str = Integer.toString(i);  // Noncompliant
+  str = Integer.toString(i); // Noncompliant
 
   for (String s : strings) {
-    s = "hello world";  // Noncompliant
+    s = "hello world"; // Noncompliant
   }
 }
 </pre>

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1212_java.json

@@ -1,10 +1,10 @@
-<p>Loggers should be:</p>
+<p>Regardless of the logging framework in use (logback, log4j, commons-logging, java.util.logging, ...), loggers should be:</p>
 <ul>
-  <li> <code>private</code>: not accessible outside of their parent classes. If another class needs to log something, it should instantiate its own
+  <li> <code>private</code>: never be accessible outside of its parent class. If another class needs to log something, it should instantiate its own
   logger. </li>
-  <li> <code>static</code>: not dependent on an instance of a class (an object). When logging something, contextual information can of course be
+  <li> <code>static</code>: not be dependent on an instance of a class (an object). When logging something, contextual information can of course be
   provided in the messages but the logger should be created at class level to prevent creating a logger along with each object. </li>
-  <li> <code>final</code>: created once and only once per class. </li>
+  <li> <code>final</code>: be created once and only once per class. </li>
 </ul>
 <h2>Noncompliant Code Example</h2>
 <p>With a default regular expression of <code>LOG(?:GER)?</code>:</p>

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1226_java.html

@@ -10,8 +10,8 @@ <h2>Noncompliant Code Example</h2>
 
   public void doSomething() {
     Set&lt;COLOR&gt; warm = new HashSet&lt;COLOR&gt;();
-    warm.add(COLORS.RED);
-    warm.add(COLORS.ORANGE);
+    warm.add(COLOR.RED);
+    warm.add(COLOR.ORANGE);
   }
 }
 </pre>
@@ -24,7 +24,7 @@ <h2>Compliant Solution</h2>
   }
 
   public void doSomething() {
-    EnumSet&lt;COLOR&gt; warm = EnumSet.of(COLOR.RED, COLOR.ORANGE);
+    Set&lt;COLOR&gt; warm = EnumSet.of(COLOR.RED, COLOR.ORANGE);
   }
 }
 </pre>

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1312_java.html

@@ -31,6 +31,6 @@ <h2>See</h2>
   <li> <a href="http://cwe.mitre.org/data/definitions/600.html">MITRE, CWE-600</a> - Uncaught Exception in Servlet </li>
   <li> <a href="https://www.securecoding.cert.org/confluence/x/s4EVAQ">CERT, ERR01-J.</a> - Do not allow exceptions to expose sensitive information
   </li>
-  <li> <a href="https://www.owasp.org/index.php/Top_10_2013-A6-Sensitive_Data_Exposure">OWASP Top Ten Category A6</a> - Sensitive Data Exposure </li>
+  <li> OWASP Top 10 2017 Category A3 - Sensitive Data Exposure </li>
 </ul>
 

java-checks/src/main/resources/org/sonar/l10n/java/rules/squid/S1641_java.html

@@ -10,7 +10,7 @@
     "cwe",
     "error-handling",
     "cert",
-    "owasp-a6"
+    "owasp-a3"
   ],
   "standards": [
     "CWE",