Attempt to fix panic when used from golangci-lint #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line panics for me, so without really understanding the intent of the code, change it to what it looks like it obviously should be doing. This fixes the panic for me at least. Apologies if this is the wrong fix.
|
Oof, thanks for spotting the error and sending a fix. I'll merge, and add a test shortly after. |
mjgarton
added a commit
to mjgarton/golangci-lint
that referenced
this pull request
Oct 27, 2025
Upgrade unparam dependency to fix a crasher bug See mvdan/unparam#89
|
Thanks for the quick response Daniel. (It seems the golangci-lint people really don't like people upgrading dependencies for them. I imagine they are tired of people "contributing" dependency upgrades simply to gain contributor recognition. Never mind, this fix will filter though eventually.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line panics for me, so without really understanding the intent of the code, change it to what it looks like it obviously should be doing.
This fixes the panic for me at least. Apologies if this is the wrong fix.