Skip to content

Add an overload initializer for UploadOptions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

andrewjl-mux
Copy link
Contributor

No description provided.

@andrewjl-mux andrewjl-mux requested a review from a team July 27, 2023 20:12
@andrewjl-mux andrewjl-mux force-pushed the ajlb/api-adjustments-for-guide branch from 2a5aafb to 4291ce2 Compare July 27, 2023 20:15
@andrewjl-mux andrewjl-mux force-pushed the ajlb/api-adjustments-for-guide branch from 4291ce2 to 13ce78a Compare July 27, 2023 20:16
public init(
eventTracking: EventTracking = .default,
inputStandardization: InputStandardization = .default,
chunkSizeInBytes: Int = 8 * 1024 * 1024,
Copy link
Contributor Author

@andrewjl-mux andrewjl-mux Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift won't allow use of a constant as a default argument in a publicly accessible method unless it is also made publicly accessible. Need to think through the right spelling for these before exposing so for now they're (sadly) repeated literals.

@andrewjl-mux andrewjl-mux added the new New feature added label Jul 28, 2023
@andrewjl-mux andrewjl-mux merged commit 5a1849e into releases/0.4.1 Jul 28, 2023
@andrewjl-mux andrewjl-mux deleted the ajlb/api-adjustments-for-guide branch July 28, 2023 19:06
@github-actions github-actions bot mentioned this pull request Jul 31, 2023
andrewjl-mux added a commit that referenced this pull request Jul 31, 2023
* Add an overload initializer for UploadOptions (#81)

* Bump version to v0.5.0

* Remove prefix use in public APIs and respell Upload as DirectUpload (#84)
tomkordic pushed a commit that referenced this pull request Mar 1, 2024
* Add an overload initializer for UploadOptions (#81)

* Bump version to v0.5.0

* Remove prefix use in public APIs and respell Upload as DirectUpload (#84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants