Skip to content

Commit 8b3aaeb

Browse files
committed
Cleaner non standard input handler invocation (#57)
1 parent 25e4872 commit 8b3aaeb

File tree

1 file changed

+10
-19
lines changed

1 file changed

+10
-19
lines changed

Sources/MuxUploadSDK/PublicAPI/MuxUpload.swift

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -484,17 +484,11 @@ public final class MuxUpload : Hashable, Equatable {
484484

485485
switch inspectionResult {
486486
case .inspectionFailure:
487-
// TODO: Request upload confirmation
488-
// before proceeding
489-
490-
guard let nonStandardInputHandler = self.nonStandardInputHandler else {
491-
self.startNetworkTransport(
492-
videoFile: videoFile
493-
)
494-
return
495-
}
496-
497-
let shouldCancelUpload = nonStandardInputHandler()
487+
// Request upload confirmation
488+
// before proceeding. If handler unset,
489+
// by default do not cancel upload if
490+
// input standardization fails
491+
let shouldCancelUpload = self.nonStandardInputHandler?() ?? false
498492

499493
if !shouldCancelUpload {
500494
self.startNetworkTransport(
@@ -546,14 +540,11 @@ public final class MuxUpload : Hashable, Equatable {
546540
videoFile: outputURL
547541
)
548542
} else {
549-
guard let nonStandardInputHandler = self.nonStandardInputHandler else {
550-
self.startNetworkTransport(
551-
videoFile: videoFile
552-
)
553-
return
554-
}
555-
556-
let shouldCancelUpload = nonStandardInputHandler()
543+
// Request upload confirmation
544+
// before proceeding. If handler unset,
545+
// by default do not cancel upload if
546+
// input standardization fails
547+
let shouldCancelUpload = self.nonStandardInputHandler?() ?? false
557548

558549
if !shouldCancelUpload {
559550
self.startNetworkTransport(

0 commit comments

Comments
 (0)