Skip to content

Commit 84d8253

Browse files
committed
Rename enum and adjust to camel casing (#36)
1 parent 055e79b commit 84d8253

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

Sources/MuxUploadSDK/Upload/UploadPersistence.swift

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,17 @@ class UploadPersistence {
120120
/// Flattened version of an upload in progress
121121
struct PersistenceEntry : Codable {
122122
let savedAt: TimeInterval
123-
let stateCode: StoredState
123+
let stateCode: PreviousStateCode
124124
let lastSuccessfulByte: UInt64
125125
let uploadInfo: UploadInfo
126126

127-
enum StoredState : Int, Codable { case was_in_progress = 0, was_paused = 1 }
127+
enum PreviousStateCode : Int, Codable {
128+
case wasInProgress = 0, wasPaused = 1
129+
}
128130

129131
func with(
130132
savedAt: TimeInterval? = nil,
131-
stateCode: StoredState? = nil,
133+
stateCode: PreviousStateCode? = nil,
132134
lastSuccessfulByte: UInt64? = nil,
133135
uploadInfo: UploadInfo? = nil
134136
) -> PersistenceEntry {
@@ -147,19 +149,19 @@ struct PersistenceEntry : Codable {
147149
// Can start again but from the beginning
148150
case .starting, .ready: return PersistenceEntry(
149151
savedAt: Date().timeIntervalSince1970,
150-
stateCode: .was_in_progress,
152+
stateCode: .wasInProgress,
151153
lastSuccessfulByte: 0,
152154
uploadInfo: upload
153155
)
154156
case .paused(let update): return PersistenceEntry(
155157
savedAt: Date().timeIntervalSince1970,
156-
stateCode: .was_paused,
158+
stateCode: .wasPaused,
157159
lastSuccessfulByte: UInt64(update.progress.completedUnitCount),
158160
uploadInfo: upload
159161
)
160162
case .uploading(let update): return PersistenceEntry(
161163
savedAt: Date().timeIntervalSince1970,
162-
stateCode: .was_in_progress,
164+
stateCode: .wasInProgress,
163165
lastSuccessfulByte: UInt64(update.progress.completedUnitCount),
164166
uploadInfo: upload
165167
)

Tests/MuxUploadSDKTests/Upload Tests/UploadPersistenceTests.swift

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ final class UploadPersistenceTests: XCTestCase {
2020
func testWrite() throws {
2121
let e1 = PersistenceEntry(
2222
savedAt: Date().timeIntervalSince1970,
23-
stateCode: .was_paused,
23+
stateCode: .wasPaused,
2424
lastSuccessfulByte: 0,
2525
uploadInfo: renameDummyUploadInfo(basename: "e1")
2626
)
2727
let e2 = PersistenceEntry(
2828
savedAt: Date().timeIntervalSince1970,
29-
stateCode: .was_paused,
29+
stateCode: .wasPaused,
3030
lastSuccessfulByte: 0,
3131
uploadInfo: renameDummyUploadInfo(basename: "e2")
3232
)
@@ -54,13 +54,13 @@ final class UploadPersistenceTests: XCTestCase {
5454
func testReadAndReadAll() throws {
5555
let e1 = PersistenceEntry(
5656
savedAt: Date().timeIntervalSince1970,
57-
stateCode: .was_paused,
57+
stateCode: .wasPaused,
5858
lastSuccessfulByte: 0,
5959
uploadInfo: renameDummyUploadInfo(basename: "e1")
6060
)
6161
let e2 = PersistenceEntry(
6262
savedAt: Date().timeIntervalSince1970,
63-
stateCode: .was_paused,
63+
stateCode: .wasPaused,
6464
lastSuccessfulByte: 0,
6565
uploadInfo: renameDummyUploadInfo(basename: "e2")
6666
)
@@ -106,13 +106,13 @@ final class UploadPersistenceTests: XCTestCase {
106106
func testRemove() throws {
107107
let e1 = PersistenceEntry(
108108
savedAt: Date().timeIntervalSince1970,
109-
stateCode: .was_paused,
109+
stateCode: .wasPaused,
110110
lastSuccessfulByte: 0,
111111
uploadInfo: renameDummyUploadInfo(basename: "e1")
112112
)
113113
let e2 = PersistenceEntry(
114114
savedAt: Date().timeIntervalSince1970,
115-
stateCode: .was_paused,
115+
stateCode: .wasPaused,
116116
lastSuccessfulByte: 0,
117117
uploadInfo: renameDummyUploadInfo(basename: "e2")
118118
)
@@ -144,13 +144,13 @@ final class UploadPersistenceTests: XCTestCase {
144144
func testCleanUpOldEntriesRemovesThreeDayOldEntries() throws {
145145
let newerEntry = PersistenceEntry(
146146
savedAt: Date().timeIntervalSince1970,
147-
stateCode: .was_paused,
147+
stateCode: .wasPaused,
148148
lastSuccessfulByte: 0,
149149
uploadInfo: renameDummyUploadInfo(basename: "newer")
150150
)
151151
let olderEntry = PersistenceEntry(
152152
savedAt: UploadPersistenceTests.OLD_ENTRY_AGE_SEC,
153-
stateCode: .was_paused,
153+
stateCode: .wasPaused,
154154
lastSuccessfulByte: 0,
155155
uploadInfo: renameDummyUploadInfo(basename: "older")
156156
)

0 commit comments

Comments
 (0)