Don't allow ABS("foo") (sqldelight#3430)

hfhbd · web-flow · commit 00a2a777e85a · 2022-08-11T17:11:28.000-04:00
Co-authored-by: hfhbd &lt;hfhbd@users.noreply.github.com&gt;
diff --git a/sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/lang/util/ExprUtil.kt b/sqldelight-compiler/src/main/kotlin/app/cash/sqldelight/core/lang/util/ExprUtil.kt
@@ -134,7 +134,7 @@ internal object AnsiSqlTypeResolver : TypeResolver {
     }
 
     "avg" -> IntermediateType(REAL).asNullable()
-    "abs" -> exprList[0].type()
+    "abs" -> encapsulatingType(exprList, INTEGER, REAL)
     "iif" -> exprList[1].type()
     "coalesce", "ifnull" -> encapsulatingType(exprList, INTEGER, REAL, TEXT, BLOB)
     "nullif" -> exprList[0].type().asNullable()

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ internal object AnsiSqlTypeResolver : TypeResolver {`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`"avg" -> IntermediateType(REAL).asNullable()`
`137`		`- "abs" -> exprList[0].type()`
	`137`	`+ "abs" -> encapsulatingType(exprList, INTEGER, REAL)`
`138`	`138`	`"iif" -> exprList[1].type()`
`139`	`139`	`"coalesce", "ifnull" -> encapsulatingType(exprList, INTEGER, REAL, TEXT, BLOB)`
`140`	`140`	`"nullif" -> exprList[0].type().asNullable()`