bug KnpLabs#1051 Boolean private needed to create private repo! (mruell)

This PR was squashed before being merged into the 3.4.x-dev branch.

Discussion
----------

Apparently there was an GitHub API change. When private is not set to `true` the visibility `private` is ignored

Commits
-------

bc93867 Boolean private needed to create private repo as seen in: https://docs.github.com/en/rest/reference/repos#create-an-organization-repository
a1f9686 Fix tests

Author: mruell

lib/Github/Api/Repo.php

@@ -205,6 +205,7 @@ public function create(
             'name'          => $name,
             'description'   => $description,
             'homepage'      => $homepage,
+            'private'       => ($visibility ?? ($public ? 'public' : 'private')) === 'private',
             'visibility'    => $visibility ?? ($public ? 'public' : 'private'),
             'has_issues'    => $hasIssues,
             'has_wiki'      => $hasWiki,

test/Github/Tests/Api/RepoTest.php

@@ -96,6 +96,7 @@ public function shouldCreateRepositoryUsingNameOnly()
                 'description'   => '',
                 'homepage'      => '',
                 'visibility'    => 'public',
+                'private'       => false,
                 'has_issues'    => false,
                 'has_wiki'      => false,
                 'has_downloads' => false,
@@ -122,6 +123,7 @@ public function shouldCreateRepositoryForOrganization()
                 'description'   => '',
                 'homepage'      => '',
                 'visibility'    => 'public',
+                'private'       => false,
                 'has_issues'    => false,
                 'has_wiki'      => false,
                 'has_downloads' => false,
@@ -153,6 +155,7 @@ public function shouldCreateRepositoryWithInternalVisibility()
                 'auto_init'     => false,
                 'has_projects'  => true,
                 'visibility'    => 'internal',
+                'private'       => false,
             ])
             ->will($this->returnValue($expectedArray));
 
@@ -372,6 +375,7 @@ public function shouldCreateUsingAllParams()
                 'description'   => 'test',
                 'homepage'      => 'http://l3l0.eu',
                 'visibility'    => 'private',
+                'private'       => true,
                 'has_issues'    => false,
                 'has_wiki'      => false,
                 'has_downloads' => false,