[From MU3 Backend] ENG-17: Fix beams in multi-voice MusicXML import #9502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of a second voice would prematurely break beams upon MusicXML import in some cases, as only one beam was stored at a time as the "current beam", and this would get thrown away if a note in another voice/track was handled before the end of a beam. This commit adds a QMap to store one beam *per voice* at a time, avoiding the conflict while retaining the existing logic.
|
I'm going to close all of these forward-ports because a lot of them deal with the same files, so it makes sense to combine them in a more intelligent way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #8108