-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use accidental width to space key signatures #9389
use accidental width to space key signatures #9389
Conversation
Compare with this For more comparison see #9390's (faling) vtests (a backport of this PR on top of the 3.x branch, as the vtests on the master branch just don't work) We can get to a denser spacing for sharp key signatures, one similar to that of MuseScore 3(.6.2) though by reducing (the default for) On the up-side: Even reducing that value to 0 does not result in that too dense appearance of MuseJazz and Petaluma, although it could be made denser still (using cutouts). |
393deb9
to
390db2c
Compare
Three updates to the PR:
Unless there's anything that needs fixing, I'm considering this PR and ready for merge (upon approval). |
390db2c
to
8fd2ab3
Compare
fix codestyle refactor for codestyle
8fd2ab3
to
8bae5cd
Compare
Looks like the vtests are failing, but the exact failure is expected with this change. |
The kerning-via-cutouts is excellent in principle, but the naturals in flat-formation are too close together. Indeed everything is a bit too tight so probably the basic spacing value should be increased slightly. |
Quick update, this PR is not ready for merge. For some reason, if the gap size style property for key signature is updated, the score does not visually update. |
You can mark the pull request as a "draft". |
Ok, assuming the tests pass, I believe the PR is ready for merging. I've updated the exact spacing values after a discussion with @oktophonie. |
fix build error
5a4aa50
to
5cf102d
Compare
Resolves: #9379
This PR uses the accidental width to calculate the spacing of key signatures. Before, all accidentals were spaced 1 space apart, regardless of font or symbol. Now, the key signature calculates each symbol's width to space them out appropriately, and the gap between them is
accidentalDistance
, the same style value used for accidentals on chords.This will provide greater consistency and clarity for accidentals.
Notes